Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExpressRoute CrossConnection Azure Ports writable #31478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomfrenzel
Copy link

Data Plane API Specification Update Pull Request

As stated inside the ExpressRoute documentation, it should be possible to change the PrimaryAzurePort and SecondaryAzurePort of a ExpressRoute CrossConnection.

See: https://learn.microsoft.com/en-us/azure/expressroute/circuit-placement-api#move-a-target-expressroute-circuit-to-a-specific-port-pair

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

As stated inside the ExpressRoute documentation, it should be possible to change the PrimaryAzurePort and SecondaryAzurePort of a ExpressRoute CrossConnection.

See: https://learn.microsoft.com/en-us/azure/expressroute/circuit-placement-api#move-a-target-expressroute-circuit-to-a-specific-port-pair
Copy link

openapi-pipeline-app bot commented Nov 8, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

Copy link

openapi-pipeline-app bot commented Nov 8, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork There is no API change compared with the previous version
Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=2c54fe7a96184708a1de8c176ad878d6
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=81e19359b25f40de912988837e9ff9ac
.Net Azure.ResourceManager.Network https://apiview.dev/Assemblies/Review/806ead8231374028b5c49cb90e200641?revisionId=ac7f3c3043bd4a4aad6eac5fd523ddd8
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=3646c549547148cd9c7a237746afaa6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required customer-reported Issues that are reported by GitHub users external to the Azure organization. Network NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants