-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add Service Upgrade API changes / Azure Search / 2025-02-01-preview #31938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
marcopiuma
wants to merge
8
commits into
Azure:efrainretana/2025-02-01-preview
Choose a base branch
from
marcopiuma:leonardogal/2025-02-01-preview/service-upgrade
base: efrainretana/2025-02-01-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5211749
Add new properties for service upgrade
b2a4fe5
Add upgrade properties to examples
49c38b1
Add example for service upgrade
1c3f28e
Add service upgrade enpoint
9cc5026
Swagger prettier changes
992937c
Fix typo
c407601
Use common systemData properties
marcopiuma 03dda0a
fix typo
marcopiuma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,7 +60,16 @@ | |
"aadAuthFailureMode": "http401WithBearerChallenge" | ||
} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": true, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -99,7 +108,16 @@ | |
"aadAuthFailureMode": "http401WithBearerChallenge" | ||
} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,16 @@ | |
}, | ||
"disableLocalAuth": true, | ||
"authOptions": null, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we have location and sku as top level values, I wonder if we should elevate systemData to a top level node vs keeping it under the properties node. |
||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -89,7 +98,16 @@ | |
}, | ||
"disableLocalAuth": true, | ||
"authOptions": null, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -93,7 +102,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -114,7 +123,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -117,7 +126,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -95,7 +104,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,16 @@ | |
}, | ||
"disabledDataExfiltrationOptions": [ | ||
"All" | ||
] | ||
], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -99,7 +108,16 @@ | |
}, | ||
"disabledDataExfiltrationOptions": [ | ||
"All" | ||
] | ||
], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,7 +60,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
}, | ||
"identity": { | ||
"type": "SystemAssigned, UserAssigned", | ||
|
@@ -109,7 +118,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
}, | ||
"identity": { | ||
"type": "SystemAssigned, UserAssigned", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,16 @@ | |
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [], | ||
"semanticSearch": "free" | ||
"semanticSearch": "free", | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
}, | ||
|
@@ -95,7 +104,16 @@ | |
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [], | ||
"semanticSearch": "free" | ||
"semanticSearch": "free", | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,16 @@ | |
"authOptions": { | ||
"apiKeyOnly": {} | ||
}, | ||
"disabledDataExfiltrationOptions": [] | ||
"disabledDataExfiltrationOptions": [], | ||
"upgradeAvailable": false, | ||
"systemData": { | ||
"createdBy": "My e-commerce app", | ||
"createdByType": "Application", | ||
"createdAt": "2024-01-01T00:00:00Z", | ||
"lastModifiedBy": "[email protected]", | ||
"lastModifiedByType": "User", | ||
"lastModifiedAt": "2024-11-01T00:00:00Z" | ||
} | ||
} | ||
} | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the "lastModified" properties are updated any time service metadata is changed by the customer, we will still need to include serviceUpgradedAt to know the version of the service was last changed. This is how we'll know the current version of the service and whether there is an upgrade available.