-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Adding new ACA Session Data Plane APIs #31996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding new ACA Session Data Plane APIs #31996
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
Thank you for your contribution shivamkm07! We will review the pull request and get back to you soon. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
...fication/app/Microsoft.App.DynamicSessions/examples/2024-10-02-preview/ListSessions_Get.json
Outdated
Show resolved
Hide resolved
...ion/app/Microsoft.App.DynamicSessions/examples/2024-10-02-preview/SessionManagement_Get.json
Outdated
Show resolved
Hide resolved
...n/app/Microsoft.App.DynamicSessions/examples/2024-10-02-preview/SessionPoolMetadata_Get.json
Outdated
Show resolved
Hide resolved
specification/app/Microsoft.App.DynamicSessions/models/session.tsp
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
...app/data-plane/Microsoft.App.DynamicSessions/preview/2024-10-02-preview/DynamicSessions.json
Outdated
Show resolved
Hide resolved
...app/data-plane/Microsoft.App.DynamicSessions/preview/2024-10-02-preview/DynamicSessions.json
Outdated
Show resolved
Hide resolved
...app/data-plane/Microsoft.App.DynamicSessions/preview/2024-10-02-preview/DynamicSessions.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR pipeline tooling is failing because of a bad example file that is already merged to main:
CodeExecution_Execute_Async_Running.json
The problem is that the headers
field is not allowed here. It should be included in the parameters
section.
A quick check of the other example files found a second occurrence of this problem in
CodeExecution_Execute_Async_Completed.json
Please open a separate PR to correct this problem (fixing just these files)
The runtime failure in the PR tooling obscures a deviation from the Azure Versioning policy. The 2024-10-02-preview API version was already merged to main in the public repo, so updates to this version must be done in a new API version. I've added the VersioningReviewRequired label by hand to signal this.
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
Signed-off-by: Shivam Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for preview. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock
Signed-off-by: Shivam Kumar <[email protected]>
PR sdk checks failing with this error due to this: This hasn't been changed in this PR. Confirming with the team to identify what to remove. |
Data Plane API Specification Update Pull Request
Related PR: https://msazure.visualstudio.com/One/_git/AAPT-Antares-Containerapps/pullrequest/11352385
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.