Release communication chat 2025 03 15 #32136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
LuChen-Microsoft
requested review from
vicancy and
mario-guerra
and removed request for
a team
github-actions
bot
added
the
brownfield
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
LuChen-Microsoft
added
the
PublishToCustomers
microsoft-github-policy-service
bot
added
the
no-recent-activity
LuChen-Microsoft
removed
the
no-recent-activity
microsoft-github-policy-service
bot
added
the
no-recent-activity
microsoft-github-policy-service
bot
removed
the
no-recent-activity
DominikMe
approved these changes
Mar 21, 2025
| "CommunicationErrorResponse": { | ||
| "$ref": "../../../Common/stable/2023-11-15/common.json#/definitions/CommunicationErrorResponse" | ||
| }, | ||
| "ErrorResponse": { |
There was a problem hiding this comment.
Is there a reason that you're adding the ErrorResponse, Error and ErrorDetail definitions? They're not being referenced and you already reference the CommunicationErrorResponse. Please remove them.
DominikMe
added
the
APIStewardshipBoard-SignedOff
microsoft-github-policy-service
bot
added
the
no-recent-activity
microsoft-github-policy-service
bot
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
#22880
#24259
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.