-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArcScope Support to ServerSites and SqlSite of Migrate RP #32212
base: main
Are you sure you want to change the base?
Add ArcScope Support to ServerSites and SqlSite of Migrate RP #32212
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
The duplicate schema failure is telling you that you have two definitions of "ErrorResponse" and "ErrorDetail" that are slightly different. I suspect this is due to references to v3 and v5 of "types.json" under "common-types/resource-management". Is there a reason why both versions are referenced? |
...ffAzure/preview/2024-12-01-preview/examples/HypervMachinesController_Get_MaximumSet_Gen.json
Outdated
Show resolved
Hide resolved
...ffAzure/preview/2024-12-01-preview/examples/HypervMachinesController_Get_MaximumSet_Gen.json
Outdated
Show resolved
Hide resolved
Wouldnt it be better instead to have a type in errors itself to let the customer know whether the error is a warning or an actual error. That ensures you dont need to maintain the count Refers to: specification/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json:19612 in f888d33. [](commit_id = f888d33, deletion_comment = False) |
Done |
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
...fication/migrate/resource-manager/Microsoft.OffAzure/preview/2024-12-01-preview/migrate.json
Outdated
Show resolved
Hide resolved
…github.com/santoshatmicrosoft/azure-rest-api-specs into AddArcScopeSupportToServerSitesAndSqlSites
@santoshatmicrosoft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.