Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documented unsupported in description #32342

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

ApnaLakshay
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Jan 27, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jan 27, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/maintenance/armmaintenance There is no API change compared with the previous version
Python azure-mgmt-maintenance https://apiview.dev/Assemblies/Review/a5c210eb5c0241e4bc65936462977902?revisionId=720e45bd725942bdade1687273a4b4d6

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 27, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Maintenance

@@ -1473,7 +1473,7 @@
"tags": [
"ConfigurationAssignments"
],
"summary": "Get configuration assignment within a subscription. This API is not implemented yet.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update doc for all API versions

@ApnaLakshay
Copy link
Member Author

#PublishToCustomers

@ApnaLakshay
Copy link
Member Author

How to add PublishToCustomers in the PR? @AzureRestAPISpecReview

Next Steps to Merge

Next steps that must be taken to merge this PR:

  • ❌ This is the public specs repo main branch which is not intended for iterative development.You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.If this is what you intend, add PublishToCustomers label to your PR.Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-reviewFor details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 29, 2025
@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 29, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 29, 2025
@gary-x-li
Copy link
Contributor

gary-x-li commented Jan 29, 2025

@ApnaLakshay Please follow https://aka.ms/azsdk/specreview/merge to get write permission. That will allow you to add labels as well as merge the PR once it's been approved.

@gary-x-li gary-x-li added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 30, 2025
@gary-x-li gary-x-li merged commit d96c413 into Azure:main Jan 31, 2025
29 checks passed
@ApnaLakshay ApnaLakshay deleted the unsupported-doc-mrp branch January 31, 2025 05:07
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
* documented unsupported in description

* Added previosu versions too for unsupported doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. customer-reported Issues that are reported by GitHub users external to the Azure organization. PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants