Skip to content

[EG] MadeRequired file separated #32435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

l0lawrence
Copy link
Member

It can be made into a csharp only client.tsp file or we can add it to the client.tsp file. I made it just for csharp rn so the 2018 swagger is generating like the 2024 version

Copy link

openapi-pipeline-app bot commented Feb 3, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Feb 3, 2025

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=d453be6eb36b49098f8ceedeed78cc6a
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=f09c3796d74e49ad9b30cc39fc4e9837
TypeSpec Azure.Messaging.EventGrid.SystemEvents Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants