Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed/Retire 2024-02-28-preview version for DeID #32538

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chrisribe
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Remove/Retire of 2024-02-28-preview api version for DeID

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Retire 2024-02-28-preview api

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Copy link

openapi-pipeline-app bot commented Feb 10, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

Copy link

openapi-pipeline-app bot commented Feb 10, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/healthdataaiservices/armhealthdataaiservices There is no API change compared with the previous version
Java azure-resourcemanager-healthdataaiservices There is no API change compared with the previous version
JavaScript @azure/arm-healthdataaiservices https://apiview.dev/Assemblies/Review/dd87545fc25c468783d62ae4e998893f?revisionId=289db1f60b4f4f18a93443f5a96bd6c4
Python azure-mgmt-healthdataaiservices https://apiview.dev/Assemblies/Review/b4370729c36f41f9bd514099f8962ffa?revisionId=5d46cbe0a08f499b9fcc1cc91c8026f1

@chrisribe chrisribe requested review from asmahmoo, jovinson-ms and a team February 10, 2025 14:41
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.HealthDataAIServices

@chrisribe
Copy link
Member Author

Removed path errors I think are to be expected since this PR removes the "2024-02-28-preview" version.
Ref of similar PR: #28811 (comment)

@chrisribe chrisribe marked this pull request as draft February 10, 2025 17:39
@AzureRestAPISpecReview AzureRestAPISpecReview removed ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test ARMReview labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk NotReadyForARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants