[EG] union updates #32560
Open
[EG] union updates #32560
+304
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
l0lawrence
commented
Feb 11, 2025
| @@ -1114,6 +1114,10 @@ union CommunicationIdentifierModelKind { | |||
| /** Microsoft Teams User */ | |||
| "microsoftTeamsUser", | |||
|
|
|||
| /** Microsoft Teams Application */ | |||
| "microsoftTeamsApp", | |||
There was a problem hiding this comment.
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
This was referenced Feb 11, 2025
[AutoPR Azure.Messaging.EventGrid.SystemEvents] [EG] union updates
azure-sdk/azure-sdk-for-net#10418
Draft
l0lawrence
requested review from
lmazuel,
jsquire and
JoshLove-msft
as code owners
|
|
||
| /** Delivered */ | ||
| "delivered", | ||
| Delivered: "delivered", |
There was a problem hiding this comment.
Why did we add the keys here but remove in the other model?
There was a problem hiding this comment.
Added the keys here b/c in this union I got twisted around on the swagger def here:
. The on the wire enum has uppercase, but values in x-ms-enum has lowercase
lmazuel
reviewed
Feb 13, 2025
| @@ -867,10 +867,10 @@ union AcsRouterLabelOperator { | |||
| /** Router Worker Selector State */ | |||
| union AcsRouterWorkerSelectorState { | |||
| /** Router Worker Selector State Active */ | |||
| Active: "active", | |||
| "active", | |||
There was a problem hiding this comment.
Suggested change
| "active", | |
| active: "active", |
Should we be explicit? Sure it's redondant, but cleaner?
There was a problem hiding this comment.
Yes I can do the same to all the unions
l0lawrence
commented
Feb 14, 2025
|
|
||
| /** Router Worker Selector State Expired */ | ||
| Expired: "expired", | ||
| expired: "expired", |
There was a problem hiding this comment.
this can go back to being capital keys
l0lawrence
commented
Feb 18, 2025
|
|
||
| string, | ||
| } | ||
|
|
||
| /** Router Worker Selector State */ | ||
| union AcsRouterWorkerSelectorState { | ||
| /** Router Worker Selector State Active */ | ||
| Active: "active", | ||
| active: "active", |
There was a problem hiding this comment.
this is capitalized by JS in GA
|
Hi, @l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
microsoft-github-policy-service
bot
added
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked all
uniontypes in system event typespec and ensured accurate key/value pairing capitalization. Found a missing value under acs