-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hybridconnectivity] Change ArmResourcePatchSync to ArmCustomPatchSync #32729
Draft
melina5656
wants to merge
1
commit into
main
Choose a base branch
from
fix-hybridconnectivity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This was referenced Feb 20, 2025
MaryGao
reviewed
Feb 26, 2025
PublicCloudConnectorProperties | ||
>; | ||
@parameterVisibility | ||
update is ArmCustomPatchSync<PublicCloudConnector, PublicCloudConnector>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline we need to keep the swagger with no change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BreakingChange-Go-Sdk
BreakingChange-JavaScript-Sdk
BreakingChange-Python-Sdk
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
PipelineBotTrigger
resource-manager
RPaaS
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ArmResourcePatchSync
toArmCustomPatchSync
and generate a new swagger.Removed
PublicCloudConnectorUpdate
,PublicCloudConnectorPeopleUpdate
,SolutionConfigurationPeopleUpdate
, andSolutionConfigurationUpdate
from the new swagger.