Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hybridconnectivity] Change ArmResourcePatchSync to ArmCustomPatchSync #32729

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melina5656
Copy link
Member

Change ArmResourcePatchSync to ArmCustomPatchSync and generate a new swagger.
Removed PublicCloudConnectorUpdate, PublicCloudConnectorPeopleUpdate, SolutionConfigurationPeopleUpdate, and SolutionConfigurationUpdate from the new swagger.

Copy link

openapi-pipeline-app bot commented Feb 20, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Feb 20, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridconnectivity/armhybridconnectivity There is no API change compared with the previous version
Java azure-resourcemanager-hybridconnectivity https://apiview.dev/Assemblies/Review/29fd73766ecc4053af99904c0d9cb57a?revisionId=0207ed0e28e841a1be0838e8dbb768e4
Python azure-mgmt-hybridconnectivity https://apiview.dev/Assemblies/Review/1eb06095c0924bed813e10739f652bc1?revisionId=94667729f21c4b02b2c73fd4f86a8720
JavaScript @azure/arm-hybridconnectivity https://apiview.dev/Assemblies/Review/244085e470344d229bc90c8196caf8af?revisionId=beb580fb22e044e489918e8ae9d49592

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 20, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.HybridConnectivity
Microsoft.HybridConnectivity

PublicCloudConnectorProperties
>;
@parameterVisibility
update is ArmCustomPatchSync<PublicCloudConnector, PublicCloudConnector>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline we need to keep the swagger with no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants