Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComputeRP 2024-11-01 #32787

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

ComputeRP 2024-11-01 #32787

wants to merge 31 commits into from

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Feb 24, 2025 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

List of changes (PRs adding new operations are ARM reviewed already):
#31092
#31425
#31519
#31933 ARM approved
#31968
#32024
#31994
#31915 ARM approved
#32361 ARM approved
#32438
#32531
#32618
#32788

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

grizzlytheodore and others added 21 commits October 8, 2024 22:39
@grizzlytheodore
copy last version as 2024-11-01
c352772
@grizzlytheodore
update swagger files version references to 2024-11-01
f8129f5
@grizzlytheodore
update version reference in example files
f2c6979
@grizzlytheodore
update readme
efdf921
@haagha
adding x-ms-paths
b97215c
@haagha
adding examples
88444a3
@haagha
Revert "adding x-ms-paths"
3ed3c17 
This reverts commit b97215c.
@haagha
Revert "adding examples"
ca4642f 
This reverts commit 88444a3.
@grizzlytheodore
resolve conflict
dd625d5
@aleclawlor
update example for 2024-11-01 (#31092)
f2648dd 
Co-authored-by: Alec Lawlor <[email protected]>
@Suchintan-microsoft
New top-level Virtual Machine property: placement (#31425)
7df7ca1 
* Added Placement property to vm, alignRegionalDisksToVMZone property to storageProfile

* 2024-11-01

* Review comments

* prettier

* br

* fixes

* Update readme.md

* Update Readme.md

* Update readme.md

* VirtualMachine - BodyTopLevelProperties suppression

* retrigger checks
@msdorahu
Add SkuProfile VMSize Rank to Compute 2024-11-01 API Version (#31519)
557cd0f 
* instance mix rank

* link example
@haagha
Adding x-ms-paths with expanded properties for VirtualMachineImages_L…
5d16a59 
…istWithProperties (#31933)

* comment

* Add x-ms-enum and x-ms-pageable properties

* adding type VirtualMachineImagesWithPropertiesListResult
@raresmihai
Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS A…
ae5a561 
…PI V2024-11-01 (#31968)

* Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01

* Run prettier on virtualMachineScaleSet.json

* Rearrange resiliencyPolicy properties according to PR comment.

* Remove AutomaticExpansionPolicy's minTargetZonalInstanceCount min and max limitations

* Remove expansionPolicy

---------

Co-authored-by: Rares-Mihai Babuta <[email protected]>
@shahan27
added priortize scale in example and scale in feature (#32024)
19ca852 
Co-authored-by: Shahan Rahman <[email protected]>
@navya-rao
Update Force Delete Description for 2024-11-01 Api Version (#31994)
1ff6006 
* update delete operation description

* adding afec details

* update virtual machine json

* moving description to parameter's description and add break tags

---------

Co-authored-by: Navya Rao <[email protected]>
@leonli1224 @grizzlytheodore
migrate vm/avset api changes (#31915)
cc5a8d8 
* migrate vm/avset api changes

* adjust according to new change

* changes according to check

* more changes to pass the check

* format

* change description

* rename test file

* fix for test

* more changes for examples and test

* fix lintdiff error

* change from 200 to 204

* add test file

* resolve lint diff

* revert

---------

Co-authored-by: Jiahui Li <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
@hmyan90 @jliusan
Update ProxyAgentSettings API Format (#32361)
46ef9d9 
* Check in ProxyAgentSettings updated format

* add suppression

* remove suppression

* restore global mode property

* more on restore gloabl mode property

* fix duplicate name of x-ms-enum

---------

Co-authored-by: judy.liu <[email protected]>
@hilaryw29
Updated description for "vmHealth" (#32438)
9b14c39 
* Updated description for "vmHealth"

* Update virtualMachine.json
@Avinash-Bondalapati
added ResilientVMDeletionStatus to Get VMScaleSet VM API and List VMS…
39b942b 
…caleSet VMs API. (#32531)

* added ResilientVMDeletionStatus

* fixed prettier issues.

* Fixed XmsEnumValidation error.

* fixed Swagger ModelValidation
@pr-work
updating network api verison for nwinterfaceConfig (#32618)
64c3e66 
Co-authored-by: Prachi Pravin Bhavsar <[email protected]>
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 24, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 24, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=dcd134c111d64ff783607a138a36aa69
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=1609adfe4195433fa84a9d9db346ac22

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 24, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels Mar 3, 2025
rkmanda
rkmanda approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 8, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 8, 2025
@rkmanda rkmanda added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed SuppressionReviewRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmanda rkmanda rkmanda approved these changes

@Sandido Sandido Awaiting requested review from Sandido Sandido is a code owner

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

@haagha haagha Awaiting requested review from haagha haagha is a code owner

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

@mabhard mabhard Awaiting requested review from mabhard mabhard is a code owner

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Compute new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.