-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subnet reference to SessionPool #32791
base: release-app-Microsoft.App-preview/2025-02-02-Preview
Are you sure you want to change the base?
Add subnet reference to SessionPool #32791
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/SessionPools.json
Show resolved
Hide resolved
fix the Swagger LintDiffFailing and Swagger PrettierCheck checks |
@razvanbadea-msft can you provide some guidance on how we can fix this error: We don't have any required properties in our object model We have this same model in our previous API versions, and also this has nothing to do with the change I'm making. How can we proceed? |
Found issue: https://github.com/Azure/typespec-azure/issues/383 - will try to implement the workaround |
/azp run |
Commenter does not have sufficient privileges for PR 32791 in repo Azure/azure-rest-api-specs |
/azp run |
Commenter does not have sufficient privileges for PR 32791 in repo Azure/azure-rest-api-specs |
Hi @ebencarek,
|
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
i think the reason for this it is because tof the tag changes in readme file { |
@jianingwang123 these are for data plane APIs which I am not trying to modify, they are already checked into the main branch. I'm just trying to add a new property in a control plane API preview version. |
@razvanbadea-msft - I changed the package tag in the readme because there was a mismatch causing a different error: I don't have any idea how to go about fixing that issue |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.