Add support for the Ipv6 private #32819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…32219) Co-authored-by: Scott Beddall <[email protected]>
* Copy files from preview/2023-10-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-10-01 Updated the API version from preview/2023-10-01-preview to stable/2024-10-01. * Added tag for 2024-10-01 in readme file * changes for 2024-10-01 --------- Co-authored-by: Younjin Song <[email protected]>
* java config * package-dir
* Backward compatibility for service networking * fix lint * fix flatten * flatten workaround * add suppression * fix doc * format
* Support incrementing semver prereleases with 'zero' versions * Make tests more explicit --------- Co-authored-by: Patrick Hallisey <[email protected]>
* Adding back Deid examples * formatting * adding back preview version to README --------- Co-authored-by: Josiah Vinson <[email protected]>
* Added label handle sdk-gen pipeline template Added common script to delete label from a PR * Update eng/common/scripts/Invoke-GitHubAPI.ps1 Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: ray chen <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]>
* commit latest API version first * ensures reviewers can see changes from new API * commit 2024-08-12-preview changes commit changes to readme * this file appears required for comparison with Azure types commit v2024-08-12-preview examples add descriptions to all new api fields adjust one of the code comments according to feedback on the Red Hat side add platformworkloadidentityroleset + examples fix relative path to common-types use common-types files directly rather than copying them into the redhatopenshift directory use common-types/v6, use ManagedServiceIdentity type definition fix Swagger SpellCheck remove "format":"uuid" from clientIds, principalIds, tenantIds attempt to fix Swagger LintDiff check convert platformWorkloadIdentities to map identity -> managedServiceIdentity rename managedServiceIdentity back to identity, use common-types directly fix UNRESOLVABLE_REFERENCE fix relative path to common types attempt to fix UNRESOLVABLE_REFERENCE fix OBJECT_MISSING_REQUIRED_PROPERTY by fixing examples attempt to fix PatchBodyParametersSchema * suppress avoidAdditionalProperties * recieved signoff from ARM team to use additionalProperties during API modeling call * fix SDK generation (duplicate type definitions) * fix SDK generation * migrate all references to common-types v6 attempt to fix SDK generation * fix ModelValidation * suppress PatchBodyParametersSchema as this patch body comes from common-types and is required * correct platformworkloadidentityrolesets to be plural * add where clause to suppressions, add reason * fix CI suppressions (where and from clauses) * Resolve ARM feedback * add singleton GETs for openShiftVersions and PWIRS * remove unused resource types machinePool, syncSet, secret, and syncIdentityProvider after a conversation with my team, as they were never used, there are no routes in our API to handle them, and they are not included in our ARM manifests * camelCase fixes * resolve Swagger ModelValidation * convert cspell to new format (see PR#32171) * add 'oidc' to cspell to resolve swagger spell check CI failure
…icenetworking (Azure#32273) * Update tspconfig.yaml * update
…lder (Azure#31826) * base commit replicating 2021-07-01-preview * Add new version of Private Links API to support metrics Following changes were made: - Added `kind` and `location` fields to Scoped Resource types: kind can currently represent either `resource`, which are all existing kinds of scoped resource, or `metrics` - Added an optional `kind` query parameter to `PrivateLinkScopesList` endpoint, for filtering - Added examples demonstrating use of the new endpoints - Fixed some typos from previous API versions * Updated examples to use the latest version * updated readme to include reference to the latest API version * fixed tag on the new API version in the readme * added the latest api version to the default tag * rolled back previous changes * Fixed MissingTypeObject, ResourceNameRestriction * Rolled back changes * changed microsoft.insights to Microsoft.Insights because apparently the lowercased version doesn't match the namespace * rearranged parameters in private link scope operation statuses * Updated default error response * Added headers for long running oeprations * Tried to correct error response templates to match the common definitions * Changed location to subscriptionLocation * Attempt to solve OperationsAPIImplementation * Revert previous change * Test moving LRO response headers * Test moving LRO response headers part 2 * Added suppression for Operations API * Following advice from reviewer to remove the 'where' tag * changed 'metrics' to 'platformMetrics', fixed examples, added example * fixed grammar error * Added enumerated values for provisioning state * introduced x-ms-enum properties * fixed examples error * changed x-ms-enum names * Added 'Canceled' to provisioningState' * attempt to solve LroLocationHeader lintdiff error * solve all the LroHeaderLocation LintDiff locations * attempt to solve DeleteResponseCodes * Fix model validation error * made kind an enum * made new fields readonly * Resolved the duplicate names issue and added a breaking change suppression * Attempt to fix the suppression for OperationsApi * Attempt to fix the suppression for OperationsApi by replicating previous pattern * Attempt to fix suppressions for lintdiff errors * removed the readonly flagged on the kind parameter - not necessary, and I'm not allowed to have readonly in the request anyway * Changed 'true' to true, fixed x-ms-enum name repeat * Changed casing * Changed enum casing * Revert "Changed enum casing" This reverts commit 16d4fe0. * removed readonly * Changed casing for kind * Test suppressions * Added suppressions for all the long-running operations lintdiff errors * Remove suppression for resourceNameRestriction to see what breaks * re-committed resource name restriction suppression * Copied private link scopes API into subfolder * Deleted duplicated api versions * Deleted 2023-06-01 from parent * reverted readme files in parent * Test git files diff * Fixed relative directories * Added location headers for async requests * Fixed location headers format * fixed location headers in examples * fixed last location header * Try modification for autorest configuration * RP naming in PascalCase * Fixed remaining lintdiff errors by copying from 2023-06-01-preview * removed unused 200 response code in delete private link scopes * Remove typespec requirements * Added typespec suppressions to preview api
Co-authored-by: Josiah Vinson <[email protected]>
* changed datamap edndpoint * regenerated file --------- Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: ray chen <[email protected]>
* add renaming for javascript sdk * update timestamp, correlationid * fixed format
…ne Specs for better SDK Generation (Azure#32249) * Make the query parameters as csv parameters * Fixing the x-ms-pageable issue * Prettier fix * Using the recommended Typespec approach
amwate
requested review from
deyaaeldeen,
kristapratico,
mssfang,
joseharriaga,
minhanh-phan,
a team,
bojunehsu,
johanste,
yangyuan,
rrahulms,
ChenglongLiu,
wilcobmsft,
wiboris,
dpwatrous,
skapur12,
cRui861,
wanghoppe,
stankovski,
jijohn14,
Juliehzl and
solankisamir
as code owners
…ft.Network-2024-07-01 Kamboj prjwl/release network microsoft.network 2024 07 01
AzureRestAPISpecReview
added
data-plane
new-api-version
RPaaS
SuppressionReviewRequired
TypeSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.