Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognitive Services 2025-04-01 #32877

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

ZhidaLiu
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-10-01 to preview/2025-04-01-preview.
Copy link

openapi-pipeline-app bot commented Feb 27, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Feb 27, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/cognitiveservices/armcognitiveservices Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-cognitiveservices https://apiview.dev/Assemblies/Review/a73850d7bd4c49edbb4d514cb6626155?revisionId=994a2776f3554856b662c75e608e1e2f
.Net Azure.ResourceManager.CognitiveServices https://apiview.dev/Assemblies/Review/6d32d60e5cfc4217b399f2d21cf6df5f?revisionId=08cae5afbf1d40a98208138e35fcaf62
JavaScript @azure/arm-cognitiveservices https://apiview.dev/Assemblies/Review/a5c5802052af4553bdae74a523c883bd?revisionId=a47caf45b7604fbdaa2e62eee513a41d
Python azure-mgmt-cognitiveservices https://apiview.dev/Assemblies/Review/0e28ee9c469a48049a651419d2c0c67a?revisionId=a523d6582a8749509469025f7c2f13c0

@ZhidaLiu ZhidaLiu force-pushed the user/zhili/CogSvc-2025-04-01-preview branch from ea7a9fb to 072c0b0 Compare February 27, 2025 04:56
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 27, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 27, 2025
@ZhidaLiu ZhidaLiu marked this pull request as ready for review February 27, 2025 20:50
@ZhidaLiu ZhidaLiu requested a review from yangyuan as a code owner February 27, 2025 20:50
@ZhidaLiu
Copy link
Member Author

The connection and capabilityHost APIs and schema are directly copied from AML RP located in:

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/connections/{connectionName}": {

we would like to keep the schema unchanged

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 27, 2025
@ZhidaLiu ZhidaLiu added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Feb 28, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels Mar 1, 2025
@debuggerXi
Copy link
Member

debuggerXi commented Mar 4, 2025

The lint diff error remain are now all caused by either the existing behavior of the Cognitive Service accounts CURD API getting copied to the accounts/projects APIs, or they are from the schema that we copied from the AML RP schema that we wish to keep (AML suppression link:

). We do want to suppress these and not block this critical version release. Due to time limit, we won't have the suppression rules now but we will work on those items in the next version.

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 5, 2025
@tadelesh
Copy link
Member

tadelesh commented Mar 7, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@AzureRestAPISpecReview AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 7, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.CognitiveServices

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 7, 2025
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 7, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 7, 2025
@rkmanda rkmanda added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Approved-Suppression and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Cognitive Services new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants