Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] convert and validate #32903

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

welovej
Copy link
Member

@welovej welovej commented Feb 28, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 28, 2025
Copy link

openapi-pipeline-app bot commented Feb 28, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Feb 28, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/storage/armstorage Create ApiView timeout. Package is too large and we cannot create ApiView for it.
JavaScript @azure/arm-storage https://apiview.dev/Assemblies/Review/b829090df7d340368696b5d166e800f2?revisionId=0d6a3055c34b4d62a4f6ac5512ba0ea0
Java azure-resourcemanager-storage-generated https://apiview.dev/Assemblies/Review/e3b9b65cf4ba4648b875e20c6221602e?revisionId=b4f00d4bd0cb4e57a912e5cda41dcefa
Python azure-mgmt-storage https://apiview.dev/Assemblies/Review/0b9508287b19466db3e14265831ea6d7?revisionId=a209a1f3b2534078a933979c14277a42

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 28, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Storage
Microsoft.Storage

@razvanbadea-msft
Copy link
Contributor

Choose a PR Template description and add a description to this pr to have the Purpose of PR and due diligence sections added

@welovej welovej marked this pull request as draft March 2, 2025 01:17
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 2, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed ARMReview labels Mar 2, 2025
welovej added 2 commits March 3, 2025 14:51
This reverts commit 7200f99.
This reverts commit 7200f99.
@github-actions github-actions bot removed the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 3, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk resource-manager Storage Storage Service (Queues, Blobs, Files) TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants