Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM Incremental TypeSpec] Return false if swagger cannot be parsed as JSON #32909

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Feb 28, 2025

Fixes this error, or any error parsing swagger that's not valid JSON:

execRoot("git show  HEAD:specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/stable/2024-06-01/appconfiguration.json")
SyntaxError: Expected ',' or '}' after property value in JSON at position 56912
    at JSON.parse (<anonymous>)
    at incrementalTypeSpec (file:///home/runner/work/azure-rest-api-specs/azure-rest-api-specs/.github/workflows/src/arm-incremental-typespec-preview.js:30:29)

https://github.com/Azure/azure-rest-api-specs/actions/runs/13528838065/job/37805953795#step:3:58

Copy link

openapi-pipeline-app bot commented Feb 28, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@mikeharder mikeharder merged commit 8607e2d into Azure:main Feb 28, 2025
10 of 24 checks passed
@mikeharder mikeharder self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎊 Closed
Development

Successfully merging this pull request may close these issues.

1 participant