Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contosowidgetmanager] Add stable API versions for testing #32966

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Mar 4, 2025

  • Some checks like BreakingChanges can only be fully tested on stable versions

sibling of https://github.com/Azure/azure-rest-api-specs-pr/pull/21734

Copy link

openapi-pipeline-app bot commented Mar 4, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@mikeharder mikeharder requested a review from weshaggard March 4, 2025 00:59
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 4, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Contoso.WidgetManager
Microsoft.Contoso
Microsoft.Contoso
Azure.Contoso.WidgetManager

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview data-plane new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 4, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 4, 2025
@mikeharder
Copy link
Member Author

.NET SDK automation failures for data plane typespec are due to the naming issues. How about adding a prefix 'contoso' to the class name?

[.Net] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/contosowidgetmanager/Azure.Template.Contoso/src/Generated/Widgets.cs(20,26): error AZC0012: Single word class names are too generic and have high chance of collision with BCL types or types from other libraries [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/contosowidgetmanager/Azure.Template.Contoso/src/Azure.Template.Contoso.csproj::TargetFramework=netstandard2.0]
01:17:32.266 cmdout 	[.Net] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/contosowidgetmanager/Azure.Template.Contoso/src/Generated/Widgets.cs(20,26): error AZC0012: Single word class names are too generic and have high chance of collision with BCL types or types from other libraries [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/contosowidgetmanager/Azure.Template.Contoso/src/Azure.Template.Contoso.csproj::TargetFramework=net8.0]
01:17:32.278 cmdout 	[.Net] Build FAILED.

Or, should we just add a TSP clientName for this property to .NET? I think this would be more correct, since this is only a problem for .NET?

Agree, this sounds better to me.

@raych1: I think I fixed this issue by adding client.tsp. But now all the SDK checks are failing. Maybe a different error? Also possible we never got SDK generation working for contoso previously.

I think this might be related to the recent TSP upgrade, which included breaking changes, which now might need to be fixed in the emitters.

@mikeharder
Copy link
Member Author

PR is blocked by azure-sdk-for-lang pipelines, until the emitters and pipelines are updated to the latest version of TypeSpec.

@weidongxu-microsoft
Copy link
Member

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@raych1
Copy link
Member

raych1 commented Mar 5, 2025

PR is blocked by azure-sdk-for-lang pipelines, until the emitters and pipelines are updated to the latest version of TypeSpec.

Looks like Java emitter has upgraded TSP based on its success in the check, but others haven't done yet.

@qiaozha
Copy link
Member

qiaozha commented Mar 7, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mikeharder
Copy link
Member Author

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mikeharder mikeharder enabled auto-merge (squash) March 7, 2025 18:31
@mikeharder mikeharder disabled auto-merge March 7, 2025 18:32
@mikeharder mikeharder added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 7, 2025
@mikeharder
Copy link
Member Author

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mikeharder mikeharder marked this pull request as draft March 7, 2025 23:08
@AzureRestAPISpecReview AzureRestAPISpecReview removed new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test ARMReview labels Mar 7, 2025
@mikeharder
Copy link
Member Author

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS TypeSpec Authored with TypeSpec
Projects
Status: 🔬 Dev in PR
Development

Successfully merging this pull request may close these issues.

7 participants