Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Enable CodeQL for JavaScript and Actions #33060

Merged
merged 9 commits into from
Mar 6, 2025
Merged

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Mar 6, 2025

Copy link

openapi-pipeline-app bot commented Mar 6, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Mar 6, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@mikeharder mikeharder changed the title [EngSys] Create codeql.yml [EngSys] Enable CodeQL for JavaScript and Actions Mar 6, 2025
pull_request:
branches: [ "main", "release-*" ]
schedule:
- cron: '27 4 * * 1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of 4:27?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the default when GH created the file for me. Maybe random, or the time I created the file? Can change to a more "standard" time if we want.

Comment on lines +47 to +49
config: |
paths:
- .github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be a multi line string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -47,12 +47,17 @@ jobs:
config: |
paths:
- .github
sparse-checkout: |
.github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to scope to only the github folder? Do we not want any other validation?

If we do want to scope it might be worth mentioning that here in a comment.

@mikeharder mikeharder merged commit 52f1deb into main Mar 6, 2025
10 of 26 checks passed
@mikeharder mikeharder deleted the mikeharder/codeql branch March 6, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🎊 Closed
Development

Successfully merging this pull request may close these issues.

[EngSys] Enable CodeQL for Actions
3 participants