[tools] console log issue from filter log #33075
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
raych1
reviewed
Mar 7, 2025
| const fullLogFileName = path.join(logFolder, `${fileNamePrefix}-full.log`); | ||
| const filteredLogFileName = path.join(logFolder, `${fileNamePrefix}-filtered.log`); | ||
| const htmlLogFileName = path.join(logFolder, `${fileNamePrefix}-${commandInput.sdkRepoName.substring("azure-sdk-for-".length)}-gen-result.html`); | ||
| return { fullLogFileName, filteredLogFileName, htmlLogFileName }; |
There was a problem hiding this comment.
Can you remove the unused code, such as other logfiles?
raych1
reviewed
Mar 7, 2025
| * @param commandInput | ||
| * @param specConfigPath | ||
| */ | ||
| function logIssuesToADO(commandInput: SpecGenSdkCmdInput, specConfigPath: string): void { |
There was a problem hiding this comment.
Suggested change
| function logIssuesToADO(commandInput: SpecGenSdkCmdInput, specConfigPath: string): void { | |
| function logIssuesToPipeline(commandInput: SpecGenSdkCmdInput, specConfigPath: string): void { |
raych1
reviewed
Mar 7, 2025
| * @param {string | undefined} readmePath The readmePath to extract the prefix from. | ||
| * @returns {string} The formatted prefix. | ||
| */ | ||
| function extractPathFromSpecConfig(tspConfigPath: string | undefined, readmePath: string | undefined): string { |
There was a problem hiding this comment.
Seems we still need this logic to find the log file name in case of batch run. Can you add a comment saying "this function is copied from 'spec-gen-sdk'" and add the source code link?
raych1
requested changes
Mar 7, 2025
There was a problem hiding this comment.
For functions generateSdkForSpecPr and generateSdkForSingleSpec,
Both tspConfigPath and readmePath can be non-empty at the same time, can you update the log group message:
logMessage(`Generating SDK from ${tspConfigPath} ${readmePath}` , LogLevel.Group);
``
In addition, resolve the lint errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
logIssuesToADOfunction to export log issues from filter log