-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Create a stable API version for Video Indexer with private endpoints #33501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
@JeffreyRichter Can you please add the required labels to the PR? for some reason we are unable to do that. |
LintDiff error is because your spec has multiple different definitions of the same enum:
|
Thanks @mikeharder. Can you help me understand how to fix it? These definitions are not part of my change (in the first iteration of the PR I copied the previous version without any changes). In reply to: 2785483382 |
per the doc linked from the error, fix is to align the enum values, or rename one of the enums.
Actually, they are part of your change. The error was introduced in your swagger in #32732, but this PR failed to update readme.md, which means the error is only being detected now. |
specification/vi/resource-manager/Microsoft.VideoIndexer/stable/2025-04-01/vi.json
Outdated
Show resolved
Hide resolved
specification/vi/resource-manager/Microsoft.VideoIndexer/stable/2025-04-01/vi.json
Outdated
Show resolved
Hide resolved
specification/vi/resource-manager/Microsoft.VideoIndexer/stable/2025-04-01/vi.json
Show resolved
Hide resolved
Choose a PR Template description and add a description to this pr to have the Purpose of PR and due diligence sections added |
@razvanbadea-msft, I tried clicking on the control plane option but nothing happened. Can you help me with this? In reply to: 2786608674 |
Hi @razvanbadea-msft , I created a new PR for this change: #34075 because Tal and Raz are currently not available to approve, and it says that merging is blocked because it needs reapproval from Tal. Could you please help with merging it? Thanks. |
Hi, @@yaeldMS. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.