Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously #33661

vikramkotturu · 2025-04-02T16:29:01Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[x ] Other, please clarify:
- This PR is just rebasing the changes to support ASE Backup which was previously ARMSigned off after review.
- URL of original PR that was ARM Signed off (based on version 2024-10-01) https://github.com/Azure/azure-rest-api-specs/assets/4429827/5bb5e7ce-8aff-4dbb-a3f8-0d9b68fef5b1
- This PR has the same changes but using the latest released version 2025-01-01 as the base.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Rebasing ASE Database Backup changes which were previously ARM Signed off

- This PR is just rebasing the changes to support ASE Database Backup which was previously ARMSigned off after review. - URL of original PR that was ARM Signed off (based on version 2024-10-01) https://github.com/Azure/azure-rest-api-specs/assets/4429827/5bb5e7ce-8aff-4dbb-a3f8-0d9b68fef5b1 - This PR has the same changes but using the latest released version 2025-01-01 as the base.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from stable/2025-01-01 to stable/2025-02-01.

openapi-pipeline-app · 2025-04-02T16:29:05Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-04-02T16:29:05Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

azure-sdk · 2025-04-02T16:43:02Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.RecoveryServices

hiaga · 2025-04-03T03:06:33Z

LGTM, please add the previous PR link which was reviewed earlier and ARMSignedOff.

pcsin · 2025-04-03T04:28:26Z

The original PR link is pointing to an image. Pls update PR description with the original PR link.

Additionally wanted to understand the intent behind this change?

vikramkotturu · 2025-04-03T05:22:52Z

Added link for previous PR that was signed off #32849

vikramkotturu · 2025-04-03T05:23:31Z

LGTM, please add the previous PR link which was reviewed earlier and ARMSignedOff.

#32849 used wrong link last time

pcsin

pcsin · 2025-04-03T06:04:23Z

Signing-off, the change rebases this version on top of released stable GA version (2025-01-01)

pcsin · 2025-04-03T12:11:10Z

Approving Avocado suppression as is done in the previous PR on which the change is based on - https://github.com/Azure/azure-rest-api-specs/pull/32231/checks?check_run_id=39827384298

Please take necessary fixes complying with Avocado automated check in subsequent iterations.

…i-specs into recoveryservicesbackup-stable2-2025-02-01

…was ARMSigned off previously (#33661) * Copy files from stable/2025-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-02-01 Updated the API version from stable/2025-01-01 to stable/2025-02-01. * Added tag for 2025-02-01 in readme file * Rebasing Sybase ASE Backup changes which were previously signed off. * Fixed prettier issues. * Pretttier fixes. * correcting passive stamp version in readme.md

…was ARMSigned off previously (Azure#33661) * Copy files from stable/2025-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-02-01 Updated the API version from stable/2025-01-01 to stable/2025-02-01. * Added tag for 2025-02-01 in readme file * Rebasing Sybase ASE Backup changes which were previously signed off. * Fixed prettier issues. * Pretttier fixes. * correcting passive stamp version in readme.md

vikramkotturu added 4 commits April 2, 2025 20:59

Copy files from stable/2025-01-01

521711f

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to stable/2025-02-01

1ff4e03

Updated the API version from stable/2025-01-01 to stable/2025-02-01.

Added tag for 2025-02-01 in readme file

11900c6

Rebasing Sybase ASE Backup changes which were previously signed off.

de91c85

microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Recovery Services Backup labels Apr 2, 2025

AzureRestAPISpecReview added ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 2, 2025

azure-sdk mentioned this pull request Apr 2, 2025

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup] Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously azure-sdk/azure-sdk-for-go#13852

Closed

Fixed prettier issues.

e00ec3a

Pretttier fixes.

d55af30

Azure deleted a comment from azure-sdk Apr 2, 2025

hiaga added AzCoreIDC PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Apr 3, 2025

hiaga approved these changes Apr 3, 2025

View reviewed changes

pcsin added the ARMChangesRequested label Apr 3, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 3, 2025

hiaga removed the ARMChangesRequested label Apr 3, 2025

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 3, 2025

pcsin approved these changes Apr 3, 2025

View reviewed changes

pcsin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 3, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 3, 2025

vikramkotturu force-pushed the recoveryservicesbackup-stable2-2025-02-01 branch from 9472e58 to d55af30 Compare April 3, 2025 10:33

pcsin added the Approved-Avocado label Apr 3, 2025

correcting passive stamp version in readme.md

fc52b93

hiaga enabled auto-merge (squash) April 3, 2025 13:32

hiaga approved these changes Apr 3, 2025

View reviewed changes

vikramkotturu added 2 commits April 3, 2025 19:58

Merge branch 'main' of https://github.com/vikramkotturu/azure-rest-ap…

14fc484

…i-specs into recoveryservicesbackup-stable2-2025-02-01

Merge branch 'main' of https://github.com/vikramkotturu/azure-rest-ap…

7a9e2fc

…i-specs into recoveryservicesbackup-stable2-2025-02-01

hiaga merged commit 49ccdfe into Azure:main Apr 4, 2025
38 of 45 checks passed

github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Apr 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously #33661

Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously #33661

vikramkotturu commented Apr 2, 2025

Uh oh!

openapi-pipeline-app bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

azure-sdk commented Apr 2, 2025 •

edited by github-actions bot

Loading

Uh oh!

hiaga commented Apr 3, 2025

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

vikramkotturu commented Apr 3, 2025

Uh oh!

vikramkotturu commented Apr 3, 2025

Uh oh!

pcsin left a comment

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously #33661

Rebasing SAP Ase Database workload backup support : 2025-02-01 which was ARMSigned off previously #33661

Conversation

vikramkotturu commented Apr 2, 2025

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-sdk commented Apr 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

hiaga commented Apr 3, 2025

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

vikramkotturu commented Apr 3, 2025

Uh oh!

vikramkotturu commented Apr 3, 2025

Uh oh!

pcsin left a comment

Choose a reason for hiding this comment

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

pcsin commented Apr 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app bot commented Apr 2, 2025 •

edited

Loading

openapi-pipeline-app bot commented Apr 2, 2025 •

edited

Loading

azure-sdk commented Apr 2, 2025 •

edited by github-actions bot

Loading