Client Rename for C# .NET SDK #33703

saitama-kunzo · 2025-04-03T17:44:07Z

SDK configuration pull request

Purpose of this PR

Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying only SDK configurations, and not API related specifications.
I have reviewed and used the respective tspconfig.yaml templates:
- ARM tspconfig template
- Data plane tspconfig template

Getting help

First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2025-04-03T17:44:11Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

openapi-pipeline-app · 2025-04-03T17:44:11Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

github-actions · 2025-04-03T17:47:27Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
TypeSpec	Qumulo.Storage

live1206 · 2025-04-07T07:40:43Z

specification/liftrqumulo/Qumulo.Storage.Management/client.tsp

@@ -1,6 +1,18 @@
 import "./main.tsp";
+import "./main.tsp";


this is duplicated with L1

live1206 · 2025-04-07T07:41:03Z

specification/liftrqumulo/Qumulo.Storage.Management/client.tsp

@@ -1,6 +1,18 @@
 import "./main.tsp";
+import "./main.tsp";
+import "./LiftrBase.Storage/main.tsp";


this is not needed, it has been imported to main.tsp already.

live1206 · 2025-04-07T07:46:26Z

/azp run

azure-pipelines · 2025-04-07T07:46:33Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

jianingwang123 · 2025-04-08T01:49:20Z

Hi @saitama-kunzo,
According to https://github.com/Azure/azure-rest-api-specs/actions/runs/14260526788/job/39970914901?pr=33703#step:4:105, your tspconfig.yaml is incorrectly configured. Kindly update your tspconfig.yaml as per the details provided below.
Please let us know if you need any further assistance.

  - Failed to find "options.@azure-tools/typespec-java.package-dir". Please add "options.@azure-tools/typespec-java.package-dir".
  - Failed to find "options.@azure-tools/typespec-go.service-dir". Please add "options.@azure-tools/typespec-go.service-dir".
  - Failed to find "options.@azure-tools/typespec-go.package-dir". Please add "options.@azure-tools/typespec-go.package-dir".
  - Failed to find "options.@azure-tools/typespec-go.module". Please add "options.@azure-tools/typespec-go.module".
  - Failed to find "options.@azure-tools/typespec-go.fix-const-stuttering". Please add "options.@azure-tools/typespec-go.fix-const-stuttering".
  - Failed to find "options.@azure-tools/typespec-go.generate-examples". Please add "options.@azure-tools/typespec-go.generate-examples".
  - Failed to find "options.@azure-tools/typespec-go.generate-fakes". Please add "options.@azure-tools/typespec-go.generate-fakes".
  - Failed to find "options.@azure-tools/typespec-go.head-as-boolean". Please add "options.@azure-tools/typespec-go.head-as-boolean".
  - Failed to find "options.@azure-tools/typespec-go.inject-spans". Please add "options.@azure-tools/typespec-go.inject-spans".
  - Failed to find "options.@azure-tools/typespec-python.package-name". Please add "options.@azure-tools/typespec-python.package-name".

saitama-kunzo · 2025-04-16T15:22:24Z

Hi @jianingwang123,
This PR only include changes related to client renaming for generating .NET SDK. Also, we are not generating java/go SDK, still do we need to add those details in the tspconfig file?
Also, for python SDK, package-name will have same value as package-dir? I cannot see this option in this sample tspconfig - https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml

jianingwang123 · 2025-04-18T07:09:48Z

Hi @jianingwang123, This PR only include changes related to client renaming for generating .NET SDK. Also, we are not generating java/go SDK, still do we need to add those details in the tspconfig file? Also, for python SDK, package-name will have same value as package-dir? I cannot see this option in this sample tspconfig - https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml

Hi @saitama-kunzo,
Previously, TypeSpec Validation did not validate tspconfig.yaml, and spec PRs could be merged even if the PR had SDK automation failures or skips. However, moving forward, TypeSpec Validation will validate tspconfig.yaml for all languages.

While the validation currently only reports warning messages, it will start reporting errors in the near future, which will block PR merges. To prevent potential issues, we highly recommend updating tspconfig.yaml according to the warning messages provided by TypeSpec Validation.

For the Python MPG SDK, there is no need to add package-name. Please disregard this. Thank you.

saitama-kunzo · 2025-04-24T02:51:38Z

Hi, @jianingwang123,
I have made the appropriate changes to the tspconfig. Please review, thanks.

…i-specs

jianingwang123 · 2025-04-25T09:09:24Z

Hi, @jianingwang123, I have made the appropriate changes to the tspconfig. Please review, thanks.

It looks like SdkTspConfigValidation has passed, thank you.

saitama-kunzo · 2025-05-09T01:26:29Z

This PR only includes changes to rename the models for generated .NET SDK. We have not made any changes to models, or code that generates python/java sdk.

Client Rename for C# .NET SDK

db1f306

AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Apr 3, 2025

azure-sdk mentioned this pull request Apr 3, 2025

[AutoPR @azure/arm-qumulo] Client Rename for C# .NET SDK azure-sdk/azure-sdk-for-js#14773

Draft

azure-sdk added the BreakingChange-JavaScript-Sdk label Apr 3, 2025

azure-sdk mentioned this pull request Apr 3, 2025

[AutoPR azure-mgmt-qumulo] Client Rename for C# .NET SDK azure-sdk/azure-sdk-for-python#11008

Draft

azure-sdk added the BreakingChange-Python-Sdk label Apr 3, 2025

Minor bug fix

1eebe3b

live1206 reviewed Apr 7, 2025

View reviewed changes

Addressed comments

6f3c6ab

Update tspconfig to include options for js/python/go

1e13ed4

saitama-kunzo added 3 commits April 24, 2025 08:24

Update tspconfig to include options for js/python/go

31ae660

Merge branch 'main' of https://github.com/saitama-kunzo/azure-rest-ap…

990c0ca

…i-specs

Merge branch 'main' into main

7c482ec

azure-sdk mentioned this pull request Apr 24, 2025

[AutoPR sdk/resourcemanager/liftrqumulo/armqumulo] Client Rename for C# .NET SDK azure-sdk/azure-sdk-for-go#14400

Draft

Merge branch 'main' into main

88de69d

azure-sdk removed the BreakingChange-Python-Sdk label May 5, 2025

azure-sdk mentioned this pull request May 5, 2025

[AutoPR Azure.ResourceManager.Qumulo] Client Rename for C# .NET SDK azure-sdk/azure-sdk-for-net#11736

Draft

Merge branch 'main' into main

7191e02

azure-sdk added the BreakingChange-Python-Sdk label May 9, 2025

saitama-kunzo added the IDCDevDiv label May 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client Rename for C# .NET SDK #33703

Client Rename for C# .NET SDK #33703

saitama-kunzo commented Apr 3, 2025

openapi-pipeline-app bot commented Apr 3, 2025 •

edited

Loading

openapi-pipeline-app bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

live1206 Apr 7, 2025

saitama-kunzo Apr 24, 2025

live1206 Apr 7, 2025

saitama-kunzo Apr 24, 2025

live1206 commented Apr 7, 2025

azure-pipelines bot commented Apr 7, 2025

jianingwang123 commented Apr 8, 2025

saitama-kunzo commented Apr 16, 2025 •

edited

Loading

jianingwang123 commented Apr 18, 2025

saitama-kunzo commented Apr 24, 2025

jianingwang123 commented Apr 25, 2025

saitama-kunzo commented May 9, 2025

Client Rename for C# .NET SDK #33703

Are you sure you want to change the base?

Client Rename for C# .NET SDK #33703

Conversation

saitama-kunzo commented Apr 3, 2025

SDK configuration pull request

Purpose of this PR

Due diligence checklist

Getting help

openapi-pipeline-app bot commented Apr 3, 2025 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Apr 3, 2025 • edited Loading

github-actions bot commented Apr 3, 2025 • edited Loading

API Change Check

live1206 Apr 7, 2025

Choose a reason for hiding this comment

saitama-kunzo Apr 24, 2025

Choose a reason for hiding this comment

live1206 Apr 7, 2025

Choose a reason for hiding this comment

saitama-kunzo Apr 24, 2025

Choose a reason for hiding this comment

live1206 commented Apr 7, 2025

azure-pipelines bot commented Apr 7, 2025

jianingwang123 commented Apr 8, 2025

saitama-kunzo commented Apr 16, 2025 • edited Loading

jianingwang123 commented Apr 18, 2025

saitama-kunzo commented Apr 24, 2025

jianingwang123 commented Apr 25, 2025

saitama-kunzo commented May 9, 2025

openapi-pipeline-app bot commented Apr 3, 2025 •

edited

Loading

openapi-pipeline-app bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

saitama-kunzo commented Apr 16, 2025 •

edited

Loading