Skip to content

Removed locale from request body #33749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Removed locale from request body #33749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1aca7a5
Removed locale from request body
abdulgagit Apr 5, 2025
59a231f
Merge branch 'main' into users/abdulgagit/remove_locale
abdulgagit Apr 7, 2025
2b7788d
Added properties around request body
abdulgagit Apr 10, 2025
dae03b6
Fixed Swagger ModelValidation
abdulgagit Apr 10, 2025
efb1b9a
Merge branch 'main' into users/abdulgagit/remove_locale
abdulgagit Apr 10, 2025
5a022e5
Merge branch 'main' into users/abdulgagit/remove_locale
abdulgagit Apr 11, 2025
d2121e9
Merge branch 'main' into users/abdulgagit/remove_locale
abdulgagit Apr 11, 2025
440875a
Updated example file
abdulgagit Apr 21, 2025
2588cfd
ModelValidation fix
abdulgagit Apr 21, 2025
0f71353
Merge branch 'main' into users/abdulgagit/remove_locale
abdulgagit May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...Microsoft.Billing/preview/2024-08-01-preview/examples/CreateOrUpdateMigrationMapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,22 @@
"billingAccountName": "57151837",
"api-version": "2024-08-01-preview",
"parameters": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "Draft"
"properties": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "Draft"
}
}
},
"responses": {
"200": {
"body": {
"id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/migrations/default",
"id": "/providers/Microsoft.Billing/billingAccounts/57151837/migrations/default",
"name": "default",
"type": "Microsoft.Billing/billingAccounts/migrations/default",
"type": "Microsoft.Billing/billingAccounts/migrations",
"properties": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "Draft",
"transferId": null,
"products": []
"status": "NotStarted",
"transferId": null
}
}
}
Expand Down
7 changes: 3 additions & 4 deletions ...ce-manager/Microsoft.Billing/preview/2024-08-01-preview/examples/GetMigrationMapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@
"responses": {
"200": {
"body": {
"id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/migrations/default",
"id": "/providers/Microsoft.Billing/billingAccounts/57151837/migrations/default",
"name": "default",
"type": "Microsoft.Billing/billingAccounts/migrations/default",
"type": "Microsoft.Billing/billingAccounts/migrations",
"properties": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "Completed",
"transferId": "4a74dc9e-a863-4c88-b11e-e76aa2f4a05d",
"products": []
"transferId": "4a74dc9e-a863-4c88-b11e-e76aa2f4a05d"
}
}
}
Expand Down
24 changes: 8 additions & 16 deletions ...urce-manager/Microsoft.Billing/preview/2024-08-01-preview/examples/InitiateMigration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,22 @@
"billingAccountName": "57151837",
"api-version": "2024-08-01-preview",
"parameters": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "InProgress",
"locale": "en-us"
"properties": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "InProgress"
}
}
},
"responses": {
"200": {
"body": {
"id": "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/migrations/default",
"id": "/providers/Microsoft.Billing/billingAccounts/57151837/migrations/default",
"name": "default",
"type": "Microsoft.Billing/billingAccounts/migrations/default",
"type": "Microsoft.Billing/billingAccounts/migrations",
"properties": {
"destinationBillingScope": "/providers/Microsoft.Billing/billingAccounts/8a1d33b5-73a1-5e7f-4b29-5afaebaba7e4:03059466-caec-4aa5-b458-2071484f7d32_2019-05-31/billingProfiles/APS5-RFWH-BG7-PGB",
"status": "Completed",
"transferId": "4a74dc9e-a863-4c88-b11e-e76aa2f4a05d",
"products": [
{
"productType": "AzureSubscription",
"productId": "43566850-63bf-40d2-a2cb-763eb62d7f3b",
"name": "OpenAI Staging",
"skuDescription": "MS-AZR-0003P",
"status": "Completed"
}
]
"status": "InProgress",
"transferId": "4a74dc9e-a863-4c88-b11e-e76aa2f4a05d"
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions ...tion/billing/resource-manager/Microsoft.Billing/preview/2024-08-01-preview/migration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/billing/resource-manager/Microsoft.Billing/preview/2024-08-01-preview/migration.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "BillingManagementClient",
Expand Down Expand Up @@ -77,7 +77,7 @@
"description": "Migration details.",
"required": true,
"schema": {
"$ref": "./types.json#/definitions/Migration"
"$ref": "#/definitions/MigrationDetails"
}
}
],
Expand Down Expand Up @@ -119,7 +119,8 @@
"properties": {
"$ref": "./types.json#/definitions/Migration"
}
}
},
"x-ms-azure-resource": true
}
},
"securityDefinitions": {
Expand Down
52 changes: 0 additions & 52 deletions ...fication/billing/resource-manager/Microsoft.Billing/preview/2024-08-01-preview/types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/billing/resource-manager/Microsoft.Billing/preview/2024-08-01-preview/types.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "BillingManagementClient",
Expand Down Expand Up @@ -31,48 +31,6 @@
},
"x-ms-azure-resource": true
},
"Products": {
"description": "Product Details.",
"type": "object",
"properties": {
"productType": {
"description": "product type",
"type": "string",
"readOnly": true
},
"productId": {
"description": "product Id",
"type": "string",
"readOnly": true
},
"name": {
"description": "product name",
"type": "string",
"readOnly": true
},
"skuDescription": {
"description": "product sku description",
"type": "string",
"readOnly": true
},
"status": {
"description": "product transfer status",
"enum": [
"NotStarted",
"InProgress",
"Completed",
"Failed"
],
"type": "string",
"readOnly": true,
"x-ms-enum": {
"name": "TransferProductStatus",
"modelAsString": true
}
}
},
"readOnly": true
},
"Migration": {
"description": "Migration Details.",
"type": "object",
Expand All @@ -96,20 +54,10 @@
"modelAsString": true
}
},
"locale": {
"description": "Locale for notifications. Optional property, used only for migrate enrollment",
"type": "string"
},
"transferId": {
"description": "Transfer Id",
"type": "string",
"readOnly": true
},
"products": {
"type": "array",
"items": {
"$ref": "#/definitions/Products"
}
}
}
}
Expand Down
Loading