Skip to content

Publish sql microsoft.sql 2024 08 01 preview #33936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ericshape
Copy link
Contributor

@ericshape ericshape commented Apr 15, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ericshape and others added 11 commits April 7, 2025 16:41
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-05-01-preview to preview/2024-08-01-preview.
revert tag for composite-v5 in readme file
* adding MemorySizeInGb to swagger #30912

* adding #31080 and #31062

* prettier fix

* prettiercheck fix
* all the content in 2024-08-01-preview

* resetting DatabaseAdvisors and VirtualClusters
* Update additional directory implementation for tsp-client (#33771)

* update additional directory implementation

* format

---------

Co-authored-by: catalinaperalta <[email protected]>

* Add retries and filter on specific ado project for the check run (#33737)

* Added retry logic

* Added retries and filter on ado project

* remove debug code

* prettier fix

* added id to the comment

* Remove use-write-core config for .NET SDK (#33754)

* [Microsoft.StorageActions] Model enum as string (#33719)

* Bump marked from 15.0.7 to 15.0.8 in /.github (#33777)

Bumps [marked](https://github.com/markedjs/marked) from 15.0.7 to 15.0.8.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v15.0.7...v15.0.8)

---
updated-dependencies:
- dependency-name: marked
  dependency-version: 15.0.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @azure-tools/typespec-client-generator-cli (#33776)

Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.17.0 to 0.18.0
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-version: 0.18.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [iothub] Update readme.python.md (#33778)

* Adding 2025-02-01 API verison for Microsoft.RecoveryServices (#33657)

* Copy files from stable/2025-01-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-02-01

Updated the API version from stable/2025-01-01 to stable/2025-02-01.

* Added tag for 2025-02-01 in readme file

* Adding source scan configuration to vault properties

* Fixing Prettier errors

* Prettier fix - 2

* Addressing PR feedback. Making IdentityType as enum

* Addressing PR comments and adding enum description

* Fixed validation

* Marketplace - PrivateStore - Get Collection Offer with Contexts View 2025-01-01 (#31976)

GetPrivateStoreCollectionOfferContextsView
- Reflects stop sell status per offer
- Fix accessibility value

* Add new API version 2025-04-01 for fluxConfigurations (#33256)

* Copy files from stable/2024-11-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-04-01

Updated the API version from stable/2024-11-01 to stable/2025-04-01.

* Added tag for 2025-04-01 in readme file

* Copy files from stable/2024-11-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-04-01

Updated the API version from stable/2024-11-01 to stable/2025-04-01.

* Added tag for 2025-04-01 in readme file

* Add provider github to new API version

* Fix prettier checks and readmes

* Delete readme files for older monolithic client

* fix case of GitHub

---------

Co-authored-by: Dipti Pai <[email protected]>

* Release redisenterprise microsoft.cache 2025-05-01-preview (#33580)

* Copy files from stable/2025-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-05-01-preview

Updated the API version from stable/2025-04-01 to preview/2025-05-01-preview.

* Added tag for 2025-05-01-preview in readme file

* include no-cluster example

* update descriptions

* Split Create and Update examples, because of different clusteringPolicy in request

* add refs to example

* Add ListSkusForScaling API and make the Database.Flush request optional

* Address PR comments

* Fix spellcheck and formatting issues

* Fix name in the response of list skus for scaling

* update examples

* Remove paging in listskusforscaling

* Remove paging in listskusforscaling

* Update as GB

* Update as GB everywhere

* Update incorrect tag

---------

Co-authored-by: Kanchan Joshi <[email protected]>
Co-authored-by: Ranjini Chithambaram (from Dev Box) <[email protected]>
Co-authored-by: Mariano Rodriguez <[email protected]>
Co-authored-by: Sivaranjini Chithambaram <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* Remove -pr from the repo name when matching the SDK repo configuration (#33774)

* Allow eng/ based packages to parse ci.yml (#33796)

Co-authored-by: Scott Beddall <[email protected]>

* fix prettier cause by script copy-apiversion (#33756)

* Support private repository in archetype-spec-gen-sdk.yml (#33643)

* [LintDiff] Add check run/workflow run verification template and wire up LintDiff check (#33766)

* Add check run/workflow run verification template and wire up LintDiff checks

* check_suite

* Apply suggestions from code review

Co-authored-by: Mike Harder <[email protected]>

* PR feedback: Populate parameters from environment

* Review feedback: Naming, permissions, condition

* Add typedef for CheckRun

* Escape

* Notices

* DRY up calls to checks.listForRef and actions.listWorkflowRunsForRepo

* Readd setFailed mock

* Formatting

* Revert "Formatting"

This reverts commit 44a9e79.

* Revert "DRY up calls to checks.listForRef and actions.listWorkflowRunsForRepo"

This reverts commit 01f73cb.

* Types, rename, replace test coverage

* Comments

* core.notice

* Remove default value

* Fix up testing to look at core.notice messages

* Add github.event_name == "workflow_ruN"

* if

* formatting

* Cover more use cases, better outputs.

* More copy editing

* Add trailing newline

* Add trailing newline

---------

Co-authored-by: Mike Harder <[email protected]>

* [Swagger Avocado] Convert to GitHub Workflow (#33782)

* Fix formatting (#33801)

* Validate api version and sdk release type values in pipeline (#33795)

* debug api version and release type check

* Match preview in the api version

* updated message

* [EngSys] context.js: Add support for "check_suite" (#33806)

* context.js: Add support for "check_suite"

* todo, formatting, types

* - getRepositoryInfo

* Apply suggestions from code review

Co-authored-by: Mike Harder <[email protected]>

* Review feedback: no spread

* Review feedback

* formatting

---------

Co-authored-by: Mike Harder <[email protected]>

* Rust renames for Key Vault (#33798)

* Rust renames for Key Vault

Mostly follows what we did for Go, which was to idiomatically match what other languages had (mostly).

* Additional renames

* Format client.tsp files

* Sync eng/common directory with azure-sdk-tools for PR 10241 (#33802)

* Use tsp-client in emitter CI

* include arg

* Check path

* remove lock scirpt

---------

Co-authored-by: jolov <[email protected]>

* release-ai-modelinference/2025-04-01 (#33549)

* Add missing backticks (#33811)

Co-authored-by: jolov <[email protected]>

* addc config (#33783)

* java, mgmt, DependencyMap, client (#33784)

* java, mgmt, DependencyMap, client

* update tspconfig.yaml

* Update specification/azuredependencymap/DependencyMap.Management/client.tsp

---------

Co-authored-by: Weidong Xu <[email protected]>

* Skip swagger apiview steps when no swagger file found (#33131)

* [Avocado] Fix "npm exec" params (#33809)

* [Avocado] Verify result of new GH Action (#33805)

* Release ACR 2025-03-01-preview (#32945)

* Copy files from preview/2024-11-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-03-01-preview

Updated the API version from preview/2024-11-01-preview to preview/2025-03-01-preview.

* Added tag for 2025-03-01-preview in readme file

* Add new properties to the 2025-03-01-preview version along with examples

* Fix lint errors

* npx prettier

* fix examples

* break tags

* whitespace

* Align common types

* add @@clientName to avoid JS SDK breakings (#33240)

Co-authored-by: Mary Gao <[email protected]>

* Update client setting for DataReplication to release .Net SDK (#33690)

* [RecoveryServices-Backup] Update readme.python.md (#33818)

* Update readme.python.md

* Update tag from package-2025-02 to package-2025-02-01

* [EngSys] Watcher - Exclude action_required conclusion as it generates false failures (#33834)

* Exclude action_required conclusion as it generates false failures

* Comments

* Durabletask 2025-04-01-preview (#33844)

* Durable Task: Add API version 2025-04-01-preview

* Bump @azure-tools/typespec-client-generator-cli (#33846)

Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-version: 0.19.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @autorest/openapi-to-typespec (#33847)

Bumps the openapi-to-typespec group with 1 update in the / directory: [@autorest/openapi-to-typespec](https://github.com/Azure/autorest).


Updates `@autorest/openapi-to-typespec` from 0.10.13 to 0.10.14
- [Release notes](https://github.com/Azure/autorest/releases)
- [Commits](https://github.com/Azure/autorest/commits)

---
updated-dependencies:
- dependency-name: "@autorest/openapi-to-typespec"
  dependency-version: 0.10.14
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: openapi-to-typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* TypeSpec updates for Java SDK (#33794)

* updating java customization

* custom union

* more java

* more java

* go back

* jobName

* doc

* compiling TypeSpec

* apply clientName to OperationState

* update OperationState client name

---------

Co-authored-by: Josiah Vinson <[email protected]>

* updated Organization patch call with marketplace details (#33839)

Co-authored-by: Srinivas Alluri <[email protected]>

* Remove UserCreatedStorageAccount and UserCreatedAcr field from swagger (#33793)

* Remove UserCreatedStorageAccount and UserCreatedAcr field from swagger

* update sample reference

* Correct package-preview-2025-03-01 to pacakge-2025-03-01-preview (#33608)

* [eng/tools] Fix LintDiff build: Use .js files locally instead of importing from .github (#33863)

* [LintDiff] New warnings pass (#33853)

* Fix the issue

* Use require.resolve (works in vitest)

* Add test coverage

* Remove unused

* Use original syntax, mock for testing

* Remove mock, use correct afterEach, use createRequire in util.ts

* Skipping platform-specific filename issues

* Revert util.ts

* lintdiff-types.js

* Set `KeyAttestation`'s visibility to "read" (#32742)

* Set KeyAttestation's visibility to "read"

* Generated swagger with latest TypeSpec changes

* Update visibility annotation for attestation field

* [sdk-breaking-change-labels] Improve perf of unit test from 7s to 7ms (#33866)

* [CDN] Fix ResourceNameRestriction for profileName Parameter (#33607)

* Fix ResourceNameRestriction

* [.github] Create package for sharing with TS projects under eng/tools (#33540)

* [.github] Install runtime deps needed for actions (#33868)

* [CogSvc] 2025-04-01-preview Contract change (#33524)

* Temp save

* Update example and more

* Fix missing def change

* Update NetworkInjections and some examples

Update examples

* Update scenario enum

* Fix typo

* Address comments

* run prettier

* Run prettier agian

* Fix lint diff

* Add associatedProjects

* Fix prettier

* Address comments

* Revert some issue

* Support run mode parameter in spec-gen-sdk runner (#33865)

* updated input params

* use full name for the param

* use new param name

* updated spec-gen-sdk version

* flipped if condition

* removed tr param

* StandbyPool update NET SDK contracts 2025-03-01 (#33705)

* Review request for Microsoft.ContainerService/aks to add version stable/2025-02-01 (#33606)

* Adds base for updating Microsoft.ContainerService/aks from version stable/2025-01-01 to version 2025-02-01

* Updates readme

* Updates API version in new specs and examples

* update python readme

* api change (#33601)

---------

Co-authored-by: Jaiveer Katariya <[email protected]>

* [.github] Merge "workflows" and ".github" into a single package (#33872)

* Bump @azure-tools/typespec-client-generator-cli (#33871)

Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-version: 0.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [chore] npm install (#33879)

* [dependabot] remove wildcards (#33880)

* [chore] npm update (#33882)

* mgmt, java, tspconfig, add back namespace option (#33881)

* add new apiVersion for dell "2025-03-21-preview" (#33821)

* add new apiVersion for dell

* update readme's

* Update tspconfig yaml file

* fix tspconfig error

* add new line at end in tspconfig yaml

* remove unused readme's and suppress lintdiff

* try fixing lintdiff check

* fix suppressions

* suppress directly in readme

* update suppressions logic

* add readme's back

* remove sdk generations from readme

* fix tspconfig errors

* fix tsp error

* fix tsp issue

* fix tsp error

* fix java sdk issue

* fix java sdk issue

* add js package

* fix failures

* update the correct readme with js packages

* revert neon's readme change

* revert js changes

---------

Co-authored-by: Vangapandu Padmapriya <[email protected]>

* [NetAppFiles] Release netapp microsoft.net app 2025 01 01 preview (#33699)

* Copy files from preview/2024-09-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-09-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* prettier

* common types v6

* subscriptionid

* from stable

* add new changes

* revert stable change

* pretty

* spelling and pattern

* revert

* empty

* REDACTED

* common types v6

* Update examples

* Update examples

* update pattern2

* [Microsoft.DataProtection] Adding Identity Details Info in all examples. Adding status code for operation status for ValidateForModifyBackup API. (#33509)

* [Microsoft.DataProtection] Adding Identity Details Info in all examples. Adding status code for operation status for ValidateForModifyBackup API.

* Adding proper description for operation status for validateforbackup and validateformodifybackup

* Adding final-state-schema

* Removing 200 status code as per updated suggest on async APIs

* Update resultLifespan for PolicyDefinition Properties (#33370)

* Remove pattern

* Update comments

---------

Co-authored-by: Celina Zhao <[email protected]>

* Configuring SDK emitter options for CopilotSettings (#33862)

* Configuring SDK emitter options for CopilotSettings

* New line at end of file

* Update specification/portalservices/CopilotSettings.Management/tspconfig.yaml

Co-authored-by: ZiWei Chen <[email protected]>

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: ZiWei Chen <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* [.github] Use execFile() instead of exec() (#33884)

- execFile(file, args) is more secure than exec(cmd)
- exec(cmd) is vulnerable to shell injection

* [TypeSpecValidation] Use execFile() instead of exec() (#33883)

- execFile(file, args) is more secure than exec(cmd)
- exec(cmd) is vulnerable to shell injection

* [.github/shared] Add ConsoleLogger (#33900)

* [.github/shared] Add consoleLogger singleton (#33903)

* Add support for threaded conversation (#32411)

* first pass on threaded conversation APIs

* use query for initiator and channel id, return 207 and error array for participant operations, fix some issues

* Update models.tsp

* cleanup

* some improvements

* Add ConversationMessageContent

* address api review feedback 1

rename initiator to participant,
fixing add/remove participants naming,
Use ResourceAction instead of ResourceCollectionAction

* address api review feedback 2

switching to ConversationMessageContent to support a broader range of message types.
Use ResourceAction (POST) with an action type of "terminate" instead of ResourceDelete

* use @withoutOmittedProperties decorator for ConversationMessageContent

* use ResourceCreateOrReplace for creating conversation instead of ResourceCollectionAction

* renaming and cleaning up

* make a few changes

/messages/conversations get    "name": "participant" => participantId
/messages/conversations/{conversationId}/messages get "name": "participant" => participantId
conversation model:  conversationId => Id
conversationMessageItem model: messageId => Id  visibility  none => read
Add a delete /messages/conversations/{conversationId} dor the real delete opeation
Use ResourceCreateWithServiceProvidedName for create converstion

* fix client error

* rewrite createConversation

have initial message as part of the request body
return conversation as a response body

* remove read only for participantIds in RemoveParticipantsRequest

* Address comments from Azure SDK Review

* fix naming

* fix naming body->options

* fix naming body->options for RemoveParticipantsOptions

* External -> external

* Rename version to 2025-04-01-preview

* fix lifecycle instead of string

* fix typo

* fix typo

* suppress and fix warnings

* add BearerAuth back and suppress the warning

* add version 2025-04-01-preview in the readme file.

* fix extra dash

* create examples

* add examples

* fix typos

* fix examples

* fix prettier

* fix examples

* fix examples

* fix breaking change

* fix breaking change warning

---------

Co-authored-by: Jim Chou <[email protected]>
Co-authored-by: Jim Chou <[email protected]>

* [sdk-suppressions] Use shared git helpers (#33901)

- Add status() to git.js

* Update enterprisePolicy.json - updating VirtualNetworkPropertiesList (#33701)

* Update enterprisePolicy.json - updating VirtualNetworkPropertiesList

We are not actually breaking the API, rather the spec was wrong from the get go and we can't change it since it's already shipped and in use code so we have to fix the documentation here.

* Create suppressions.yaml

adding suppression file powerplatform

* Update specification/powerplatform/suppressions.yaml

Co-authored-by: Mike Harder <[email protected]>

---------

Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: catalinaperalta <[email protected]>
Co-authored-by: catalinaperalta <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Minghao Chen <[email protected]>
Co-authored-by: Risheek Rajolu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Rishav Raj <[email protected]>
Co-authored-by: saviesacov <[email protected]>
Co-authored-by: dipti-pai <[email protected]>
Co-authored-by: Dipti Pai <[email protected]>
Co-authored-by: Kanchan Joshi <[email protected]>
Co-authored-by: Kanchan Joshi <[email protected]>
Co-authored-by: Ranjini Chithambaram (from Dev Box) <[email protected]>
Co-authored-by: Mariano Rodriguez <[email protected]>
Co-authored-by: Sivaranjini Chithambaram <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Tianen <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: jolov <[email protected]>
Co-authored-by: Facundo Santiago <[email protected]>
Co-authored-by: Judy Liu <[email protected]>
Co-authored-by: Hong Li(MSFT) <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Wei Meng <[email protected]>
Co-authored-by: ZiWei Chen <[email protected]>
Co-authored-by: Mary Gao <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Co-authored-by: Josiah Vinson <[email protected]>
Co-authored-by: Josiah Vinson <[email protected]>
Co-authored-by: Srinivas <[email protected]>
Co-authored-by: Srinivas Alluri <[email protected]>
Co-authored-by: chaoyu-msft <[email protected]>
Co-authored-by: curiekim00 <[email protected]>
Co-authored-by: vcolin7 <[email protected]>
Co-authored-by: Chenglong Liu <[email protected]>
Co-authored-by: ZhidaLiu <[email protected]>
Co-authored-by: carlosh-msft2025 <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
Co-authored-by: Jaiveer Katariya <[email protected]>
Co-authored-by: Padmapriya-09 <[email protected]>
Co-authored-by: Vangapandu Padmapriya <[email protected]>
Co-authored-by: Auðunn <[email protected]>
Co-authored-by: Dishant Munjal <[email protected]>
Co-authored-by: ccz77 <[email protected]>
Co-authored-by: Celina Zhao <[email protected]>
Co-authored-by: karanvsingh1 <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: glorialimicrosoft <[email protected]>
Co-authored-by: Jim Chou <[email protected]>
Co-authored-by: Jim Chou <[email protected]>
Co-authored-by: Christopher Merino Brito <[email protected]>
* databaseadvisor and virtualcluster changes

* removing virtualcluter, raise as part of new PR
* virtualcluster changes

* updated VirtualClusterCreate
@ericshape ericshape requested a review from jamestao as a code owner April 15, 2025 00:09
Copy link

openapi-pipeline-app bot commented Apr 15, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Apr 15, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@ericshape ericshape requested a review from jeremyfrosti April 15, 2025 00:11
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Apr 15, 2025
Copy link

github-actions bot commented Apr 15, 2025

API Change Check

API changes are not detected in this pull request.

@ericshape
Copy link
Contributor Author

rebase

@ericshape
Copy link
Contributor Author

breaking change has been approved and merged in

#31080 , #31062 and #30912
#30969, #31008, #31181

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label May 5, 2025
@thewulf7
Copy link

rebase

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label May 13, 2025
@thewulf7
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 33936 in repo Azure/azure-rest-api-specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version NotReadyForARMReview resource-manager SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants