[eg] fix record<unknown> #34100
Open
[eg] fix record<unknown> #34100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0lawrence
requested review from
lmazuel,
jsquire and
JoshLove-msft
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
|
Can we link to the issue? |
JoshLove-msft
approved these changes
Apr 21, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
This was referenced Apr 21, 2025
|
fixes #34053 |
| @@ -93,7 +93,8 @@ model DeviceConnectionStateEventProperties { | |||
| /** Schema of the Data property of an EventGridEvent for a device telemetry event (DeviceTelemetry). */ | |||
| model DeviceTelemetryEventProperties { | |||
| /** The content of the message from the device. */ | |||
| body: Record<{}>; | |||
| #suppress "@azure-tools/typespec-azure-core/bad-record-type" "The type of body is object" | |||
| body: Record<unknown>; | |||
There was a problem hiding this comment.
Is this based off the examples?
There was a problem hiding this comment.
so I based this on that the type in the swagger is just object without additionalProperties specified -- let me check the examples
There was a problem hiding this comment.
|
Hi, @@l0lawrence. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
microsoft-github-policy-service
bot
added
the
no-recent-activity
| @@ -758,8 +757,7 @@ alias AcsChatThreadBaseEventData = { | |||
| createdByCommunicationIdentifier: CommunicationIdentifierModel; | |||
|
|
|||
| /** The thread properties */ | |||
| #suppress "@azure-tools/typespec-azure-core/bad-record-type" "The type of properties is object with additionalProperties: object" | |||
| properties: Record<unknown>; | |||
| properties: Record<{}>; | |||
There was a problem hiding this comment.
Apparently, these should be Record<Record<unknown>>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to swap Record to Record<{}> where additionalProperties is an object