Skip to content

Conversation

@v-anishrao
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 23, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 23, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Migrate-AssessmentProjects

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Apr 23, 2025
@v-anishrao v-anishrao added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Apr 23, 2025
@v-anishrao
Copy link
Contributor Author

Rationale for adding Versioning-Approved-BugFix label

This previous PR #33791 authored by me had operations API defined in each of the sub services. This is wrong as the RP has only one operations API at the RP level which is used to display all the operations from every sub service.

This PR simply removes operations defined by every other sub service to a common place attached to the Same API-Version which is accurate.
Followed an example from here: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/workloads/Workloads.Operations.Management/models.tsp

Moreover, this started causing problems for the other pipelines like ApiDoc which is also fixed with this PR.

@v-anishrao v-anishrao added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jun 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jun 23, 2025
@microsoft-github-policy-service
Copy link
Contributor

Hi, @@v-anishrao. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jul 14, 2025
auto-merge was automatically disabled July 28, 2025 13:00

Pull request was closed

@microsoft-github-policy-service
Copy link
Contributor

Hi, @@v-anishrao. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC no-recent-activity There has been no recent activity on this issue. PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants