Skip to content

[TSP Migration]--datadog #34281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
welovej wants to merge 39 commits into from
Closed

[TSP Migration]--datadog #34281

welovej wants to merge 39 commits into from

Conversation

@welovej
Copy link
Member

@welovej welovej commented Apr 28, 2025 •
edited by pshao25
Loading

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind. This is the list you need to pay attention:

  • Common type version is lower than 3.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 28, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 28, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Datadog
Go sdk/resourcemanager/datadog/armdatadog
JavaScript @azure/arm-datadog
Java com.azure.resourcemanager:azure-resourcemanager-datadog

@azure-sdk azure-sdk mentioned this pull request Apr 28, 2025
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec labels Apr 28, 2025
This was referenced Apr 28, 2025
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Apr 28, 2025
Closed
This was referenced Apr 28, 2025
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request May 9, 2025
Closed
weidongxu-microsoft
weidongxu-microsoft reviewed May 9, 2025
View reviewed changes
Pan Shao and others added 3 commits May 9, 2025 15:34
welovej added 3 commits August 5, 2025 14:57
@welovej
fix for typespec migration validation
80be29c 
Comparing finished.
| Type | Level | Message |
| ---- | ----- | ------- |
| finalresult | error | The finalresult of operation "Monitors_Create" changed: "DatadogMonitorResource" -> undefined |
| finalresult | error | The finalresult of operation "Monitors_Update" changed: "DatadogMonitorResource" -> undefined |
| finalresult | error | The finalresult of operation "SingleSignOnConfigurations_CreateOrUpdate" changed: "DatadogSingleSignOnResource" -> undefined |
| finalresult | error | The finalresult of operation "MonitoredSubscriptions_CreateorUpdate" changed: "MonitoredSubscriptionProperties" -> undefined |
| finalresult | error | The finalresult of operation "MonitoredSubscriptions_Update" changed: "MonitoredSubscriptionProperties" -> undefined |
@welovej
Revert "fix for typespec migration validation"
5f8f3dc 
This reverts commit 80be29c.
@welovej
update
e1d953d
@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@pshao25 pshao25 mentioned this pull request Aug 22, 2025
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Sep 15, 2025
@mzhongl524 mzhongl524 mentioned this pull request Sep 16, 2025
Closed
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Sep 29, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Oct 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Nov 10, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Nov 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Dec 15, 2025
@pshao25 pshao25 closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tadelesh tadelesh tadelesh left review comments

@johanste johanste johanste left review comments

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@v-jiaodi v-jiaodi v-jiaodi left review comments

@pshao25 pshao25 pshao25 left review comments

@JiaqiZhang-Dev JiaqiZhang-Dev JiaqiZhang-Dev left review comments

Assignees

No one assigned

Labels

ARMReview BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview resource-manager RPaaS rpaas-tsp-conversion TypeSpec Authored with TypeSpec typespec-conversion-w2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.