-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[DataDog] SDK validation for TypeSpec swagger #52641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Show resolved
Hide resolved
sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs
Outdated
Show resolved
Hide resolved
|
The error in pipeline is because this PR generated the SDK code through local validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure DataDog SDK to reflect changes from a new TypeSpec swagger specification. The changes primarily involve API surface modifications including model renames, new API endpoints, and property name updates following .NET naming conventions.
- Updates API surface with renamed models and methods following better naming conventions (e.g., DatadogAgreementResourceProperties → DataDogAgreementResourceContent)
- Adds new functionality for creation support checking and billing information retrieval
- Introduces monitored subscription property management capabilities
Reviewed Changes
Copilot reviewed 6 out of 107 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/datadog/Azure.ResourceManager.Datadog/tests/Azure.ResourceManager.Datadog.Tests.csproj | Adds folder structure for generated samples |
| sdk/datadog/Azure.ResourceManager.Datadog/src/autorest.md | Updates swagger source reference and adds extensive rename mappings for better .NET naming conventions |
| sdk/datadog/Azure.ResourceManager.Datadog/src/Azure.ResourceManager.Datadog.csproj | Adds folder structure for generated extensions |
| sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.netstandard2.0.cs | Updates public API surface with renamed types, new methods, and additional properties |
| sdk/datadog/Azure.ResourceManager.Datadog/api/Azure.ResourceManager.Datadog.net8.0.cs | Mirrors the netstandard2.0 API changes for .NET 8.0 target |
| .vscode/cspell.json | Adds "Cspm" to the dictionary for DataDog-specific terminology |
| namespace: Azure.ResourceManager.Datadog | ||
| require: https://github.com/Azure/azure-rest-api-specs/blob/066eb8c81e14e0f3b22b6700c67693eef5f79ea9/specification/datadog/resource-manager/readme.md | ||
| require: https://github.com/Azure/azure-rest-api-specs-pr/blob/30f23d89b692f80b495fb7f45c3e695872460bd1/specification/datadog/resource-manager/readme.md | ||
| # tag: package-2025-06 rpaas |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment '# tag: package-2025-06 rpaas' appears to contain debugging or temporary notes ('rpaas'). This should either be removed if it's not needed, or properly documented if it serves a specific purpose in the configuration.
| # tag: package-2025-06 rpaas |
|
The error in pipeline is because this PR generated the SDK code through local validation. |
|
Hi @mzhongl524. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @mzhongl524. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
This is the SDK validation for DataDog.
TSP link: https://github.com/Azure/azure-rest-api-specs-pr/pull/24680.
Generate SDK code from Swagger and it seems that there are no significant changes.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.