-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DO NOT MERGE] TEST TEST Creating a new TestService with new structure layout #34537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
@weshaggard I commented out the tests that need to be changed to support the new directory structure. The TypeSpec validation tests are now passing. |
@@ -0,0 +1,48 @@ | |||
# containerstorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffreyRichter Should the readme.md file but under the service/rp folder or in the root of resource-manager
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RP & data-plane, there is one readme.md file per service in the ServiceName folder. This readme.md is required for docs & for SDK creation from swaggers (but not from TypeSpec).
The RP Namespace folder also needs a readme.md file required for RPaaS schema validation.
We should also add the data-plane version of this to ensure that works as well. |
Avocado is failing because it is detecting the example json files with the tsp project and not seeing them referenced anywhere. |
@@ -0,0 +1,63 @@ | |||
import "@typespec/rest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename Contoso.Management folder to just Contoso. We already know it's management because it's under resource-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wess requested a data-plane example to be part of this PR.
So, under data-plane folder, there should 1 or 2 ServiceName folders identical in structure to that under the Microsoft.Contoso RP namespace folder. Data-plane does not have an RP namespace folder and does not have a readme.md files in this folder. The only readme.md files are in the ServiceName folders.
Closing as Mike as another test PR |
Test that changes folder name to lower case as per Wes' review.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.