-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Review request for Microsoft.ContainerService/aks to add version preview/2025-03-02-preview #34593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Review request for Microsoft.ContainerService/aks to add version preview/2025-03-02-preview #34593
Conversation
…eview/2025-02-02-preview to version preview/2025-03-02-preview
Co-authored-by: Lily Pan <[email protected]>
Co-authored-by: Lily Pan <[email protected]>
* Add localDNSProfile to AgentpoolProfile for LocalDNS feature * Add Localdns profile * Updated prettied code
* Change namespace to managedNamespace * refactor * fix pipeline
…34223) * Add SchedulerProfile and associated types to v20250302preview API. * fix missing close curly brace * make upstream into a simple field in schedulerInstanceProfiles --------- Co-authored-by: Alex Benn <[email protected]>
* Add SchedulerProfile and associated types to v20250302preview API. * fix bad merge. * Switch enum 'None' to 'Default', which is more descriptive. --------- Co-authored-by: Alex Benn <[email protected]>
* update to managed namespace in 2025-03-02-preview * refactor * revert Change namespace to managedNamespace (#34286) * refactor date
* chore: add new ubuntu OSSKUs to rest API spec * fix: reorder --------- Co-authored-by: anujmaheshwari1 <[email protected]>
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Co-authored-by: Li Ma <[email protected]>
![]() https://github.com/Azure/azure-rest-api-specs/pull/34593/checks?check_run_id=42057592712 This is a false alert. The results are based on a comparison between the new preview and stable API versions. In the stable API, the IstioEgressGateway model definition does not even contain the name attribute, let alone setting it to read only. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.