-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add ACS Call Automation GA6 #34830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ACS Call Automation GA6 #34830
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Updated example for Start Recording with the async response code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. A few minor comments may need your input.
AI summary
Summary of Changes from 2025-05-15 to 2025-06-15
1. Reference Updates
Changed Common schema references from stable 2023-11-15 to preview 2025-03-15-preview
Communication identifiers and models now reference from the newer preview path
For example: CommunicationIdentifierModel, PhoneNumberIdentifierModel, CommunicationUserIdentifierModel, etc.
2. StartCallRecordingRequest Changes
Removed the required property constraint for callLocator
Added support for using callConnectionId as an alternative to callLocator
This provides a more flexible way to identify the call for recording operations
The API now includes a description indicating "Only one of callLocator or callConnectionId to be used"
3. Common Model Updates
Added TeamsExtensionUserIdentifierModel reference from Common schema
Added MicrosoftTeamsAppIdentifierModel reference from Common schema
4. CreateCallRequest Extension
Added a new property teamsAppSource of type MicrosoftTeamsAppIdentifierModel
This allows specifying a Teams app as the source when creating a call with Teams resource account ID
5. WebSocketMediaStreamingOptions Enhancement
Added enableDtmfTones property
This provides a flag to indicate whether to stream DTMF tones in the media stream
6. Common Schema Version Alignment
The API now uses the consistent Common schema version across all model references
This ensures consistent behavior between related Communication Services APIs
...ication/data-plane/CallAutomation/stable/2025-06-15/communicationservicescallautomation.json
Outdated
Show resolved
Hide resolved
"callLocator": { | ||
"$ref": "#/definitions/CallLocator", | ||
"description": "The call locator. (Only one of callLocator or callConnectionId to be used)" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 2025-05-01, this property is "required"
"required": [
"callLocator"
],
So this is also a break. Though you probably intend this for adding callConnectionId
.
(it is mentioned in CI https://github.com/Azure/azure-rest-api-specs/pull/34830/checks?check_run_id=42662219511)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out. The change from required
to optional
for callLocator
was intentional and was previously approved. As you mentioned, the API still supports usage of callLocator
, but now also gives clients the option to use callConnectionId
instead. This makes the API more flexible while maintaining backward compatibility.
Edit: Either a callLocator or callConnectionId must always be provided
Please let me know if you have further concerns or need additional clarification.
cc: @khannavikas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few minor issues that I think need to be resolved.
...ication/data-plane/CallAutomation/stable/2025-06-15/communicationservicescallautomation.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Release planner
A release plan should have been created. If not, please create one as it will help guide you through the REST API and SDK creation process.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.