Skip to content

2025-05-15-preview Entitysynonym bug fix #34955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

quentinRobinson
Copy link
Member

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Release planner

A release plan should have been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@quentinRobinson quentinRobinson requested a review from yangyuan as a code owner May 27, 2025 18:17
Copy link

openapi-pipeline-app bot commented May 27, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 27, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@quentinRobinson quentinRobinson added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 27, 2025
Copy link

github-actions bot commented May 27, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Language.Text
Swagger AnomalyDetector-Language

@AzureRestAPISpecReview AzureRestAPISpecReview added TypeSpec Authored with TypeSpec and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels May 27, 2025
@quentinRobinson quentinRobinson added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 27, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels May 27, 2025
@quentinRobinson quentinRobinson added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels May 27, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 27, 2025
@quentinRobinson quentinRobinson added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 27, 2025
Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock codeowner approval. No review needed.

@quentinRobinson quentinRobinson added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label May 27, 2025
@quentinRobinson quentinRobinson merged commit d676d70 into Azure:main May 27, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior Cognitive Services data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants