Skip to content

Update stable version PR #35002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: release-machinelearningservices-Microsoft.MachineLearningServices-2025-06-01_fromStable
Choose a base branch
from

Conversation

fmabroukmsft
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Modification PR to existing new API version PR

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

ethanlao-microsoft and others added 30 commits May 27, 2025 16:04
* Update ApiManagementCreateOpenIdConnectProvider.json

* Update ApiManagementCreateOpenIdConnectProvider.json

* Update ApiManagementCreateOpenIdConnectProvider.json

* rest of examples
Bumps [globals](https://github.com/sindresorhus/globals) from 16.1.0 to 16.2.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v16.1.0...v16.2.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-version: 16.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [globals](https://github.com/sindresorhus/globals) from 16.1.0 to 16.2.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v16.1.0...v16.2.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-version: 16.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [DNM] Validate hotfix typespec-azure#2742

* update parameter of legacy from body to resource

* undo no needed changes

* bump version

---------

Co-authored-by: Alitzel Mendez <[email protected]>
* entitysynonym bug fix

* tsv fixes

---------

Co-authored-by: Bidisha Chakraborty <[email protected]>
…#34580)

* Initial changes

* Finalizing changes

* Minor change

* Fixes

* Fix format

* Add scenario for 2025-04-01-preview

* Add read mutability to createMode, restoreParameters and replicaParameters

* Update examples to include SSDv2 and authConfig properties

* Fix prettier

* Recompile
* update the model to DeploymentResourceJobState

* change the api and model version to 2023-04-15-preview
* LintDiff: Fix correlations and usage of Readme objects

* Simulate LintDiff error

* Example autorest fatal error

* Revert widgets.json

* Improve testing for buildState to cover equality comparison

* Improve test coverage for correlateRuns

* Skip testing on Windows
…atch (#34801)

* Removed conflicting fields from Ngroup definition and created NGroupPatch
* deleted obsolete doc and script

* updated generate sdk step

* updated reference in other docs and folder structure page
* added more options for openapi batch runs

* expose options in pipeline yml
* add vitest config && using type from shared folder

* bugfix for shared type

* using new shared script to get pr changed files

* bugfix for correct script path

* bugfix for filter sdk-suppressions.yaml file

* bugfix for init input changefiles

* fix comment

* add config for tspconfig

* bugfix for args length

* remove vite.config.ts & remove reference for tsconfig

* fix prettier issue

* revert tsconfig.json
…bSub (#34732)

* Init from 2024-10-01-preview

* 2025-01-01-preview update

* Update readme for new version

* Add route settings example
…4809)

* PaloAltoNetworks.Cloudngfw-2024-02-07-stable version from preview

* added stable version tag to readme

* latest stable version

* changing the operation id in 2025-05-23 stable version

---------

Co-authored-by: Rohit Kumar <[email protected]>
…4678)

* Update Pipeline.json

* Update Pipeline.json

* Update Pipeline.json

* Update sdk-suppressions.yaml

* add suppressiom

---------

Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: Judy Liu <[email protected]>
Co-authored-by: Jingshu918 <[email protected]>
…e Extensibility (#34712)

Communication Common API
* added TeamsExtensionUser as a kind of CommunicationIdentifier
* added new members to PhoneNumberIdentifierModel

Communication Identity API
* added "get/put/update" to manipulate TeamsPhone user assignment (route "/access/teamsExtension/tenants/{tenantId}/assignments/{objectId}")
* added "post" to exchange token for TeamsPhone Extensibility (route "/access/teamsExtension/:exchangeAccessToken")
* add tsp

* fix tsp config

* Fix versioning

* Add Rating and Reviews API operations and examples

* rename the folder

* update tspconfig

* fix some typespec errors

* update service decorator

* remove versioning

* update to tsp compiler

* remove unused readme

* undo remove readme

* add readme

* fix version

* swagger lint diff fixes

* fix get response

* after tsp compile

* change operation to POST

* fix routing

* update tsp config

* add java config

* fix hava confing

* fix typo

* fill all sdks in config

* fix ts confing

* test

* fix ts confing errors

* fix config errors

* set package dir

* upate more config errors

* remove suppressions for nested resource in Reviews configuration

* change verb name to checkUserHasReview

* fix typo

* checking doc can replace comments

* fix PR review requests

* fix RP comments
* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json

* Update registries.json
* Update copilot instructions to generate SDK locally
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-04-01 to stable/2025-06-01.
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label May 30, 2025
Copy link

github-actions bot commented May 30, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.MachineLearningServices
Go sdk/resourcemanager/machinelearning/armmachinelearning
Java com.azure.resourcemanager:azure-resourcemanager-machinelearning
C# Azure.ResourceManager.MachineLearning
JavaScript @azure/arm-machinelearning
Python azure-mgmt-machinelearningservices_python.json

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 30, 2025
@fmabroukmsft fmabroukmsft removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PipelineBotTrigger ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.