Skip to content

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Jul 10, 2025

migrated from #33517

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

Theodore Chang added 2 commits July 10, 2025 15:55
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Compute
Go sdk/resourcemanager/compute/armcompute
Java com.azure.resourcemanager:azure-resourcemanager-compute-generated
JavaScript @azure/arm-compute
C# Azure.ResourceManager.Compute

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jul 28, 2025
@haagha haagha reopened this Aug 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Aug 12, 2025
@haagha haagha merged commit 50d6150 into feature/cplat-2025-04-01-tsp Aug 19, 2025
100 of 111 checks passed
@haagha haagha deleted the feature/cplat-2025-04-01-tsp-galleryScriptReferenceId branch August 19, 2025 15:18
@haagha haagha mentioned this pull request Aug 29, 2025
9 tasks
haagha added a commit that referenced this pull request Sep 15, 2025
* add new version to main.tsp

* add examples in the new folder

* fix main.tsp

* swagger files generated

* update readme.md

* import versioing

* Tags to network properties in vm/vmss (#35830)

Tags to network properties in vm/vmss

* Adding property HighSpeedInterconnectPlacemen (#35832)

* latestOperationStatus and lastStatusChangeTime to OrchestrationServiceSummary (#35827)

* Add ScheduledEvents Versioning changes (#36111)

* Add galleryScriptReferenceId parameter to runCommand.json  (#35828)

* add support for ProxyAgentSettings Extension installation. (#36669)

Co-authored-by: Haider Agha <[email protected]>

* Capacity Block TypeSpec Updates (#36604)

* Add ScaleOut API (#35914)

* update

* suppress lintDiff

* fix parameter name

* unflatten property bag

---------

Co-authored-by: Haider Agha <[email protected]>

* Adding Placement, MaxZoneCount and MaxInstancePercent for VMSS (#36121)

* Adding Placement, MaxZoneCount and MaxInstancePercent

* Adding examples

* Restricting placement property to version 2025-04-01+

* Update field for maxInstancePercentPerZonePolicy

* Suppress BodyTopLevelProperties for VirtualMachineScaleSet to accommodate Placement

* Moving examples to tsp folder

* Adding reason in readme.md for BodyTopLevelProperty suppression

* Add upgradePolicy to example templates

* Update documentation of the Placement property

* Update documentation for Placement

---------

Co-authored-by: Haider Agha <[email protected]>

* Remove redundant import of Versioning in VirtualMachineScaleSet.tsp

* Add suppression for LroAzureAsyncOperationHeader in ComputeRP.json

* Fix typo in suppression reason for LroAzureAsyncOperationHeader in readme.md

* fix spellcheck

* Fix indentation in suppression reason for LroAzureAsyncOperationHeader in readme.md

* add patch name masks for inclusion and exclusion (#37094)

Co-authored-by: Haider Agha <[email protected]>

* Changed common types to v6

* Revert "Changed common types to v6"

This reverts commit ece385a.

* Update operation status change time description to specify UTC format

* Remove suppression for LroAzureAsyncOperationHeader in readme.md

* DisableCapacityReservationAssignment Property TypeSpec Changes (#37228)

* add disableCapacityReservationAssignment property

* add example for VMSS

* added example/update

* Fix errors

---------

Co-authored-by: Payal LNU <[email protected]>
Co-authored-by: Haider Agha <[email protected]>

* Revert "DisableCapacityReservationAssignment Property TypeSpec Changes (#37228)"

This reverts commit 286090c.

---------

Co-authored-by: xinzewang <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: payalguptapg <[email protected]>
Co-authored-by: Haider Agha <[email protected]>
Co-authored-by: Sarojini Devi Govindaraju <[email protected]>
Co-authored-by: Samudra Banerjee <[email protected]>
Co-authored-by: Razvan Badea <[email protected]>
Co-authored-by: btyu1 <[email protected]>
Co-authored-by: Payal LNU <[email protected]>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Sep 18, 2025
* add new version to main.tsp

* add examples in the new folder

* fix main.tsp

* swagger files generated

* update readme.md

* import versioing

* Tags to network properties in vm/vmss (Azure#35830)

Tags to network properties in vm/vmss

* Adding property HighSpeedInterconnectPlacemen (Azure#35832)

* latestOperationStatus and lastStatusChangeTime to OrchestrationServiceSummary (Azure#35827)

* Add ScheduledEvents Versioning changes (Azure#36111)

* Add galleryScriptReferenceId parameter to runCommand.json  (Azure#35828)

* add support for ProxyAgentSettings Extension installation. (Azure#36669)

Co-authored-by: Haider Agha <[email protected]>

* Capacity Block TypeSpec Updates (Azure#36604)

* Add ScaleOut API (Azure#35914)

* update

* suppress lintDiff

* fix parameter name

* unflatten property bag

---------

Co-authored-by: Haider Agha <[email protected]>

* Adding Placement, MaxZoneCount and MaxInstancePercent for VMSS (Azure#36121)

* Adding Placement, MaxZoneCount and MaxInstancePercent

* Adding examples

* Restricting placement property to version 2025-04-01+

* Update field for maxInstancePercentPerZonePolicy

* Suppress BodyTopLevelProperties for VirtualMachineScaleSet to accommodate Placement

* Moving examples to tsp folder

* Adding reason in readme.md for BodyTopLevelProperty suppression

* Add upgradePolicy to example templates

* Update documentation of the Placement property

* Update documentation for Placement

---------

Co-authored-by: Haider Agha <[email protected]>

* Remove redundant import of Versioning in VirtualMachineScaleSet.tsp

* Add suppression for LroAzureAsyncOperationHeader in ComputeRP.json

* Fix typo in suppression reason for LroAzureAsyncOperationHeader in readme.md

* fix spellcheck

* Fix indentation in suppression reason for LroAzureAsyncOperationHeader in readme.md

* add patch name masks for inclusion and exclusion (Azure#37094)

Co-authored-by: Haider Agha <[email protected]>

* Changed common types to v6

* Revert "Changed common types to v6"

This reverts commit ece385a.

* Update operation status change time description to specify UTC format

* Remove suppression for LroAzureAsyncOperationHeader in readme.md

* DisableCapacityReservationAssignment Property TypeSpec Changes (Azure#37228)

* add disableCapacityReservationAssignment property

* add example for VMSS

* added example/update

* Fix errors

---------

Co-authored-by: Payal LNU <[email protected]>
Co-authored-by: Haider Agha <[email protected]>

* Revert "DisableCapacityReservationAssignment Property TypeSpec Changes (Azure#37228)"

This reverts commit 286090c.

---------

Co-authored-by: xinzewang <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: payalguptapg <[email protected]>
Co-authored-by: Haider Agha <[email protected]>
Co-authored-by: Sarojini Devi Govindaraju <[email protected]>
Co-authored-by: Samudra Banerjee <[email protected]>
Co-authored-by: Razvan Badea <[email protected]>
Co-authored-by: btyu1 <[email protected]>
Co-authored-by: Payal LNU <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants