Skip to content

Conversation

@hushamz26
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Storage Storage Service (Queues, Blobs, Files) label Sep 19, 2025
@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 19, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Storage
Go sdk/resourcemanager/storage/armstorage
Java com.azure.resourcemanager:azure-resourcemanager-storage-generated
JavaScript @azure/arm-storage
C# Azure.ResourceManager.Storage

{
"swagger": "2.0",
"info": {
"version": "2025-06-01",
Copy link
Member

@blueww blueww Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merge the PR, the Rest API change in new API version will be public, and will be in rest API doc, ARM template, ... (besides PSH/CLI/SDK)

To avoid customer issue, before merge this PR, please make sure:

  1. The new API version is available in all regions (include usgov, mooncake ...)
  2. All existing APIs (especially task assignment) are still available with the new API version in all regions it works with old API version.
  3. All new API changes are available with the new API version in all regions .
  4. If some new API change will not be available in some regions by design, please point it out, and share the error message when user use the API in not supported regions. The error message should be clear and actionable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The API version has been deployed to PROD/Fairfax/Mooncake
  2. This has been tested.
  3. The new API features for GEO and OR are rolling out right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Any region still not has it. If all regions has the new API version, pleas confirm.
  2. Please confirm all existing apis are tested on new API version, especially task assignment.
  3. Please raise when the deployment finish, then merge this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All regions have the new API and it has been tested. Wei Wei, as Imani mentioned in the email thread that ps/cli will be in preview state first.

Copy link
Member

@blueww blueww Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the change is in stable API version, it will be in GA SDK, and rest API Doc with GA API version, and many other things like ARM template.
So all the APIs need work with the API version in all regions (or with clear&actionable error message), else we might get customer issue. No matter PSH/CLI is GA or preview.

Copy link
Member

@blueww blueww Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tested put task assignment with 2025-06-01 in eastus2, and it doesn't work, the error is following.
So it looks 2025-06-01 is still not deployed for task assignment API.

"error": {
"code": "NoRegisteredProviderFound",
"message": "No registered resource provider found for location 'eastus2' and API version '2025-06-01' for type 'storageAccounts/storageTaskAssignments'. The supported api-versions are '2021-09-01, 2022-05-01, 2022-09-01, 2023-01-01, 2023-04-01, 2023-05-01, 2024-01-01, 2025-01-01'. The supported locations are 'malaysiawest, chilecentral, austriaeast, qatarcentral, canadacentral, francecentral, westeurope, westus2, australiaeast, northcentralus, brazilsouth, northeurope, centralus, centralindia, westus, germanywestcentral, switzerlandnorth, australiasoutheast, eastus2, japaneast, japanwest, southindia, westcentralus, uksouth, ukwest, koreacentral, koreasouth, australiacentral, southafricanorth, uaenorth, norwayeast, westus3, swedencentral, italynorth, israelcentral, spaincentral, southafricawest, uaecentral, switzerlandwest, germanynorth, norwaywest, brazilsoutheast, jioindiacentral, southcentralus, eastus2stage, eastusstg, eastus2euap, centraluseuap, polandcentral, australiacentral2, newzealandnorth, indonesiacentral, westindia, canadaeast, eastus, jioindiawest, eastasia, southeastasia, mexicocentral'."
}

As my comment send 2 days ago "Please confirm all existing apis are tested on new API version, especially task assignment."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`GET https://management.chinacloudapi.cn/subscriptions/881a2b5b-2cde-46a0-9bd6-4a66131dc288/resourceGroups/ServiceFabricScenarioTests2/providers/Microsoft.Storage/storageAccounts/5clxt52fmrqmo3?api-version=2025-06-01&_1759956877949

{
"responses": [
{
"name": "417c39eb-14a0-4415-8e9f-87984d4c500b",
"httpStatusCode": 200,
"headers": {
"Pragma": "no-cache",
"x-ms-request-id": "a791e05c-2446-4d9e-84a5-3f919c8b9c69",
"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
"x-ms-ratelimit-remaining-subscription-reads": "243",
"x-ms-ratelimit-remaining-subscription-global-reads": "3743",
"x-ms-correlation-request-id": "022f0af3-d2bd-4391-86cd-129feb461289",
"x-ms-routing-request-id": "CHINANORTH3:20251008T205438Z:50a4807d-546a-4804-b5c9-a264e185f296",
"X-Content-Type-Options": "nosniff",
"Cache-Control": "no-cache",
"Date": "Wed, 08 Oct 2025 20:54:38 GMT",
"Server": "Microsoft-Azure-Storage-Resource-Provider/1.0,Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0"
},
"content": {
"sku": {
"name": "Standard_LRS",
"tier": "Standard"
},
"kind": "Storage",
"id": "/subscriptions/881a2b5b-2cde-46a0-9bd6-4a66131dc288/resourceGroups/ServiceFabricScenarioTests2/providers/Microsoft.Storage/storageAccounts/5clxt52fmrqmo3",
"name": "5clxt52fmrqmo3",
"type": "Microsoft.Storage/storageAccounts",
"location": "chinanorth2",
"tags": {
"resourceType": "Service Fabric",
"clusterName": "sfctests2"
},
"properties": {
"keyCreationTime": {
"key1": "2025-03-25T09:58:24.2750853Z",
"key2": "2025-03-25T09:58:24.2750853Z"
},
"privateEndpointConnections": [],
"minimumTlsVersion": "TLS1_0",
"allowBlobPublicAccess": false,
"networkAcls": {
"ipv6Rules": [],
"bypass": "AzureServices",
"virtualNetworkRules": [],
"ipRules": [],
"defaultAction": "Allow"
},
"supportsHttpsTrafficOnly": false,
"encryption": {
"services": {
"file": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-03-25T09:58:24.2750853Z"
},
"blob": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-03-25T09:58:24.2750853Z"
}
},
"keySource": "Microsoft.Storage"
},
"provisioningState": "Succeeded",
"creationTime": "2025-03-25T09:58:24.1969461Z",
"primaryEndpoints": {
"blob": "https://5clxt52fmrqmo3.blob.core.chinacloudapi.cn/",
"queue": "https://5clxt52fmrqmo3.queue.core.chinacloudapi.cn/",
"table": "https://5clxt52fmrqmo3.table.core.chinacloudapi.cn/",
"file": "https://5clxt52fmrqmo3.file.core.chinacloudapi.cn/"
},
"primaryLocation": "chinanorth2",
"statusOfPrimary": "available"
}
},
"contentLength": 1390
}
]
}`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Even the GET call for the last one https://management.usgovcloudapi.net/subscriptions/709ecc39-176f-41ea-acc4-3493f35e45ba/resourcegroups/kavyatest/providers/Microsoft.Storage/storageAccounts/dfvfdfffff?api-version=2025-06-01&_1759953716294|

succeeds ,
{
"responses": [
{
"name": "7498c5a4-c58c-4137-b915-9f521963f079",
"httpStatusCode": 200,
"headers": {
"Pragma": "no-cache",
"x-ms-request-id": "a5ff6f5d-d346-4f61-bd1d-6eb65c95f78c",
"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
"x-ms-ratelimit-remaining-subscription-reads": "249",
"x-ms-ratelimit-remaining-subscription-global-reads": "3749",
"x-ms-correlation-request-id": "bc38e8de-675b-4033-a739-b8837f70e067",
"x-ms-routing-request-id": "USGOVARIZONA:20251008T200156Z:e4794623-e2b8-4bb8-b21a-881097869fa6",
"X-Content-Type-Options": "nosniff",
"Cache-Control": "no-cache",
"Date": "Wed, 08 Oct 2025 20:01:56 GMT",
"Server": "Microsoft-Azure-Storage-Resource-Provider/1.0,Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0"
},
"content": {
"sku": {
"name": "Standard_RAGRS",
"tier": "Standard"
},
"kind": "StorageV2",
"id": "/subscriptions/709ecc39-176f-41ea-acc4-3493f35e45ba/resourceGroups/kavyatest/providers/Microsoft.Storage/storageAccounts/dfvfdfffff",
"name": "dfvfdfffff",
"type": "Microsoft.Storage/storageAccounts",
"location": "usgovtexas",
"tags": {},
"properties": {
"allowCrossTenantDelegationSas": false,
"dualStackEndpointPreference": {
"defaultDualStackEndpoints": false,
"publishIpv4Endpoint": false,
"publishIpv6Endpoint": false
},
"publicNetworkAccess": "Enabled",
"keyCreationTime": {
"key1": "2025-10-08T20:00:39.6821329Z",
"key2": "2025-10-08T20:00:39.6821329Z"
},
"allowCrossTenantReplication": false,
"privateEndpointConnections": [],
"minimumTlsVersion": "TLS1_2",
"allowBlobPublicAccess": false,
"allowSharedKeyAccess": true,
"largeFileSharesState": "Enabled",
"networkAcls": {
"ipv6Rules": [],
"bypass": "AzureServices",
"virtualNetworkRules": [],
"ipRules": [],
"defaultAction": "Allow"
},
"supportsHttpsTrafficOnly": true,
"encryption": {
"requireInfrastructureEncryption": false,
"services": {
"file": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-10-08T20:00:39.6821329Z"
},
"blob": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-10-08T20:00:39.6821329Z"
}
},
"keySource": "Microsoft.Storage"
},
"accessTier": "Hot",
"provisioningState": "Succeeded",
"creationTime": "2025-10-08T20:00:39.6196227Z",
"primaryEndpoints": {
"dfs": "https://dfvfdfffff.dfs.core.usgovcloudapi.net/",
"web": "https://dfvfdfffff.z5.web.core.usgovcloudapi.net/",
"blob": "https://dfvfdfffff.blob.core.usgovcloudapi.net/",
"queue": "https://dfvfdfffff.queue.core.usgovcloudapi.net/",
"table": "https://dfvfdfffff.table.core.usgovcloudapi.net/",
"file": "https://dfvfdfffff.file.core.usgovcloudapi.net/"
},
"primaryLocation": "usgovtexas",
"statusOfPrimary": "available",
"secondaryLocation": "usgovarizona",
"statusOfSecondary": "available",
"secondaryEndpoints": {
"dfs": "https://dfvfdfffff-secondary.dfs.core.usgovcloudapi.net/",
"web": "https://dfvfdfffff-secondary.z5.web.core.usgovcloudapi.net/",
"blob": "https://dfvfdfffff-secondary.blob.core.usgovcloudapi.net/",
"queue": "https://dfvfdfffff-secondary.queue.core.usgovcloudapi.net/",
"table": "https://dfvfdfffff-secondary.table.core.usgovcloudapi.net/"
}
}
},
"contentLength": 2185
}
]
}`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wei Wei - usgov and mooncake regions have been validated with new api version above.

"info": {
"title": "StorageManagementClient",
"description": "Storage Resource Provider API Common Types",
"version": "2025-06-01"
Copy link
Member

@blueww blueww Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storage/resource-manager/readme.md is not updated.
Please refer to before SRP API version upgrade PR (e.g. #33529) to see all files need change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the readme

Copy link
Member

@blueww blueww Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please compare with the before swagger PR, and confirm all files need update are updated.

(For the SDK language specific change, should be owned by SDK team. It's OK not in this PR.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared files changed look the same with th exception of sdk langauge specific files and sdk-supressions.yaml

@chmari chmari self-requested a review September 24, 2025 17:00
@sandipsh
Copy link
Contributor

    "isBlobEnabled": {

is it readonly?


Refers to: specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/storage.json:5944 in f967fe6. [](commit_id = f967fe6, deletion_comment = False)

@sandipsh
Copy link
Contributor

    "isBlobEnabled": {

oh never mind, looks like it is not.


In reply to: 3330982757


Refers to: specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/storage.json:5944 in 20385cb. [](commit_id = 20385cb, deletion_comment = False)

@sandipsh sandipsh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2025
@josefree
Copy link
Member

josefree commented Oct 9, 2025

A PR converting the SRP service to TypeSpec has been prepped by the Azure SDK team as part of the drive to move all existing Azure services to use TypeSpec. The PR for this is
#35403
. The team owning this service will need to validate the PR, address any highlighted linter failures, make any service-specific changes to the PR, have a review with ARM, and complete the PR before any additional work can be done on the service. Information regarding how to do this finalization and who to contact for assistance are at https://azure.github.io/typespec-azure/docs/migrate-swagger/01-get-started/#review-and-adjust-the-typespec. Going forward, any change to the service spec will need to be performed with TypeSpec.

pshao25
pshao25 previously requested changes Oct 9, 2025
Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we communicated offline, let's get TypeSpec conversion merged first and bump new version on the TypeSpec. Let me know if you have any concern.

Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure task assignment API deployment will be ready before 10/24.
Or the SDK release target 10/24 will be blocked, or we might will have customer issue.

@chmari chmari added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed SuppressionReviewRequired labels Oct 10, 2025
@hushamz26
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

@hushamz26 hushamz26 closed this Oct 14, 2025
@hushamz26 hushamz26 reopened this Oct 14, 2025
@pshao25 pshao25 dismissed their stale review October 14, 2025 01:19

We SDK team have tried our best to meet the hard timeline for the new version including all the SDK validations and preparing TypeSpec PR for the new version. However, service team failed to validate API in the canary environment. Therefore, TypeSpec conversion PR cannot be merged. I dismiss my blocking to let the new version of swagger go in first. We will adjust the converted TypeSpec to the new version later. Please help continue to validate the API in canary environment to proceed TypeSpec migration. Really appreciate your cooperation.

@hushamz26 hushamz26 merged commit ef72f8c into main Oct 14, 2025
107 checks passed
@hushamz26 hushamz26 deleted the personal/hushamhusham/api20250601 branch October 14, 2025 01:52
pmoana-ms pushed a commit that referenced this pull request Oct 23, 2025
* Add API version 2025-06-01 for Microsoft.Storage

* change to new api version 2025-06-01

* add property for get/patch/put

* add new geo priorty proprety examples

* add readme file

* [ORS] Swagger 2025-06-01 add priorityReplication (#37681)

---------

Co-authored-by: Husham Zahid <[email protected]>
Co-authored-by: Christian Marin <[email protected]>
Co-authored-by: ZiWei Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS service-under-conversion Storage Storage Service (Queues, Blobs, Files) SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants