-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add API version 2025-06-01 for Microsoft.Storage #37597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/blob.json
Show resolved
Hide resolved
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2025-06-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merge the PR, the Rest API change in new API version will be public, and will be in rest API doc, ARM template, ... (besides PSH/CLI/SDK)
To avoid customer issue, before merge this PR, please make sure:
- The new API version is available in all regions (include usgov, mooncake ...)
- All existing APIs (especially task assignment) are still available with the new API version in all regions it works with old API version.
- All new API changes are available with the new API version in all regions .
- If some new API change will not be available in some regions by design, please point it out, and share the error message when user use the API in not supported regions. The error message should be clear and actionable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The API version has been deployed to PROD/Fairfax/Mooncake
- This has been tested.
- The new API features for GEO and OR are rolling out right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Any region still not has it. If all regions has the new API version, pleas confirm.
- Please confirm all existing apis are tested on new API version, especially task assignment.
- Please raise when the deployment finish, then merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All regions have the new API and it has been tested. Wei Wei, as Imani mentioned in the email thread that ps/cli will be in preview state first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the change is in stable API version, it will be in GA SDK, and rest API Doc with GA API version, and many other things like ARM template.
So all the APIs need work with the API version in all regions (or with clear&actionable error message), else we might get customer issue. No matter PSH/CLI is GA or preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just tested put task assignment with 2025-06-01 in eastus2, and it doesn't work, the error is following.
So it looks 2025-06-01 is still not deployed for task assignment API.
"error": {
"code": "NoRegisteredProviderFound",
"message": "No registered resource provider found for location 'eastus2' and API version '2025-06-01' for type 'storageAccounts/storageTaskAssignments'. The supported api-versions are '2021-09-01, 2022-05-01, 2022-09-01, 2023-01-01, 2023-04-01, 2023-05-01, 2024-01-01, 2025-01-01'. The supported locations are 'malaysiawest, chilecentral, austriaeast, qatarcentral, canadacentral, francecentral, westeurope, westus2, australiaeast, northcentralus, brazilsouth, northeurope, centralus, centralindia, westus, germanywestcentral, switzerlandnorth, australiasoutheast, eastus2, japaneast, japanwest, southindia, westcentralus, uksouth, ukwest, koreacentral, koreasouth, australiacentral, southafricanorth, uaenorth, norwayeast, westus3, swedencentral, italynorth, israelcentral, spaincentral, southafricawest, uaecentral, switzerlandwest, germanynorth, norwaywest, brazilsoutheast, jioindiacentral, southcentralus, eastus2stage, eastusstg, eastus2euap, centraluseuap, polandcentral, australiacentral2, newzealandnorth, indonesiacentral, westindia, canadaeast, eastus, jioindiawest, eastasia, southeastasia, mexicocentral'."
}
As my comment send 2 days ago "Please confirm all existing apis are tested on new API version, especially task assignment."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"responses": [
{
"name": "417c39eb-14a0-4415-8e9f-87984d4c500b",
"httpStatusCode": 200,
"headers": {
"Pragma": "no-cache",
"x-ms-request-id": "a791e05c-2446-4d9e-84a5-3f919c8b9c69",
"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
"x-ms-ratelimit-remaining-subscription-reads": "243",
"x-ms-ratelimit-remaining-subscription-global-reads": "3743",
"x-ms-correlation-request-id": "022f0af3-d2bd-4391-86cd-129feb461289",
"x-ms-routing-request-id": "CHINANORTH3:20251008T205438Z:50a4807d-546a-4804-b5c9-a264e185f296",
"X-Content-Type-Options": "nosniff",
"Cache-Control": "no-cache",
"Date": "Wed, 08 Oct 2025 20:54:38 GMT",
"Server": "Microsoft-Azure-Storage-Resource-Provider/1.0,Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0"
},
"content": {
"sku": {
"name": "Standard_LRS",
"tier": "Standard"
},
"kind": "Storage",
"id": "/subscriptions/881a2b5b-2cde-46a0-9bd6-4a66131dc288/resourceGroups/ServiceFabricScenarioTests2/providers/Microsoft.Storage/storageAccounts/5clxt52fmrqmo3",
"name": "5clxt52fmrqmo3",
"type": "Microsoft.Storage/storageAccounts",
"location": "chinanorth2",
"tags": {
"resourceType": "Service Fabric",
"clusterName": "sfctests2"
},
"properties": {
"keyCreationTime": {
"key1": "2025-03-25T09:58:24.2750853Z",
"key2": "2025-03-25T09:58:24.2750853Z"
},
"privateEndpointConnections": [],
"minimumTlsVersion": "TLS1_0",
"allowBlobPublicAccess": false,
"networkAcls": {
"ipv6Rules": [],
"bypass": "AzureServices",
"virtualNetworkRules": [],
"ipRules": [],
"defaultAction": "Allow"
},
"supportsHttpsTrafficOnly": false,
"encryption": {
"services": {
"file": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-03-25T09:58:24.2750853Z"
},
"blob": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-03-25T09:58:24.2750853Z"
}
},
"keySource": "Microsoft.Storage"
},
"provisioningState": "Succeeded",
"creationTime": "2025-03-25T09:58:24.1969461Z",
"primaryEndpoints": {
"blob": "https://5clxt52fmrqmo3.blob.core.chinacloudapi.cn/",
"queue": "https://5clxt52fmrqmo3.queue.core.chinacloudapi.cn/",
"table": "https://5clxt52fmrqmo3.table.core.chinacloudapi.cn/",
"file": "https://5clxt52fmrqmo3.file.core.chinacloudapi.cn/"
},
"primaryLocation": "chinanorth2",
"statusOfPrimary": "available"
}
},
"contentLength": 1390
}
]
}`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`Even the GET call for the last one https://management.usgovcloudapi.net/subscriptions/709ecc39-176f-41ea-acc4-3493f35e45ba/resourcegroups/kavyatest/providers/Microsoft.Storage/storageAccounts/dfvfdfffff?api-version=2025-06-01&_1759953716294|
succeeds ,
{
"responses": [
{
"name": "7498c5a4-c58c-4137-b915-9f521963f079",
"httpStatusCode": 200,
"headers": {
"Pragma": "no-cache",
"x-ms-request-id": "a5ff6f5d-d346-4f61-bd1d-6eb65c95f78c",
"Strict-Transport-Security": "max-age=31536000; includeSubDomains",
"x-ms-ratelimit-remaining-subscription-reads": "249",
"x-ms-ratelimit-remaining-subscription-global-reads": "3749",
"x-ms-correlation-request-id": "bc38e8de-675b-4033-a739-b8837f70e067",
"x-ms-routing-request-id": "USGOVARIZONA:20251008T200156Z:e4794623-e2b8-4bb8-b21a-881097869fa6",
"X-Content-Type-Options": "nosniff",
"Cache-Control": "no-cache",
"Date": "Wed, 08 Oct 2025 20:01:56 GMT",
"Server": "Microsoft-Azure-Storage-Resource-Provider/1.0,Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0"
},
"content": {
"sku": {
"name": "Standard_RAGRS",
"tier": "Standard"
},
"kind": "StorageV2",
"id": "/subscriptions/709ecc39-176f-41ea-acc4-3493f35e45ba/resourceGroups/kavyatest/providers/Microsoft.Storage/storageAccounts/dfvfdfffff",
"name": "dfvfdfffff",
"type": "Microsoft.Storage/storageAccounts",
"location": "usgovtexas",
"tags": {},
"properties": {
"allowCrossTenantDelegationSas": false,
"dualStackEndpointPreference": {
"defaultDualStackEndpoints": false,
"publishIpv4Endpoint": false,
"publishIpv6Endpoint": false
},
"publicNetworkAccess": "Enabled",
"keyCreationTime": {
"key1": "2025-10-08T20:00:39.6821329Z",
"key2": "2025-10-08T20:00:39.6821329Z"
},
"allowCrossTenantReplication": false,
"privateEndpointConnections": [],
"minimumTlsVersion": "TLS1_2",
"allowBlobPublicAccess": false,
"allowSharedKeyAccess": true,
"largeFileSharesState": "Enabled",
"networkAcls": {
"ipv6Rules": [],
"bypass": "AzureServices",
"virtualNetworkRules": [],
"ipRules": [],
"defaultAction": "Allow"
},
"supportsHttpsTrafficOnly": true,
"encryption": {
"requireInfrastructureEncryption": false,
"services": {
"file": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-10-08T20:00:39.6821329Z"
},
"blob": {
"keyType": "Account",
"enabled": true,
"lastEnabledTime": "2025-10-08T20:00:39.6821329Z"
}
},
"keySource": "Microsoft.Storage"
},
"accessTier": "Hot",
"provisioningState": "Succeeded",
"creationTime": "2025-10-08T20:00:39.6196227Z",
"primaryEndpoints": {
"dfs": "https://dfvfdfffff.dfs.core.usgovcloudapi.net/",
"web": "https://dfvfdfffff.z5.web.core.usgovcloudapi.net/",
"blob": "https://dfvfdfffff.blob.core.usgovcloudapi.net/",
"queue": "https://dfvfdfffff.queue.core.usgovcloudapi.net/",
"table": "https://dfvfdfffff.table.core.usgovcloudapi.net/",
"file": "https://dfvfdfffff.file.core.usgovcloudapi.net/"
},
"primaryLocation": "usgovtexas",
"statusOfPrimary": "available",
"secondaryLocation": "usgovarizona",
"statusOfSecondary": "available",
"secondaryEndpoints": {
"dfs": "https://dfvfdfffff-secondary.dfs.core.usgovcloudapi.net/",
"web": "https://dfvfdfffff-secondary.z5.web.core.usgovcloudapi.net/",
"blob": "https://dfvfdfffff-secondary.blob.core.usgovcloudapi.net/",
"queue": "https://dfvfdfffff-secondary.queue.core.usgovcloudapi.net/",
"table": "https://dfvfdfffff-secondary.table.core.usgovcloudapi.net/"
}
}
},
"contentLength": 2185
}
]
}`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wei Wei - usgov and mooncake regions have been validated with new api version above.
| "info": { | ||
| "title": "StorageManagementClient", | ||
| "description": "Storage Resource Provider API Common Types", | ||
| "version": "2025-06-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storage/resource-manager/readme.md is not updated.
Please refer to before SRP API version upgrade PR (e.g. #33529) to see all files need change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please compare with the before swagger PR, and confirm all files need update are updated.
(For the SDK language specific change, should be owned by SDK team. It's OK not in this PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared files changed look the same with th exception of sdk langauge specific files and sdk-supressions.yaml
oh never mind, looks like it is not. In reply to: 3330982757 Refers to: specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/storage.json:5944 in 20385cb. [](commit_id = 20385cb, deletion_comment = False) |
|
A PR converting the SRP service to TypeSpec has been prepped by the Azure SDK team as part of the drive to move all existing Azure services to use TypeSpec. The PR for this is |
pshao25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we communicated offline, let's get TypeSpec conversion merged first and bump new version on the TypeSpec. Let me know if you have any concern.
specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/storage.json
Show resolved
Hide resolved
blueww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure task assignment API deployment will be ready before 10/24.
Or the SDK release target 10/24 will be blocked, or we might will have customer issue.
|
@microsoft-github-policy-service agree company="Microsoft" |
We SDK team have tried our best to meet the hard timeline for the new version including all the SDK validations and preparing TypeSpec PR for the new version. However, service team failed to validate API in the canary environment. Therefore, TypeSpec conversion PR cannot be merged. I dismiss my blocking to let the new version of swagger go in first. We will adjust the converted TypeSpec to the new version later. Please help continue to validate the API in canary environment to proceed TypeSpec migration. Really appreciate your cooperation.
* Add API version 2025-06-01 for Microsoft.Storage * change to new api version 2025-06-01 * add property for get/patch/put * add new geo priorty proprety examples * add readme file * [ORS] Swagger 2025-06-01 add priorityReplication (#37681) --------- Co-authored-by: Husham Zahid <[email protected]> Co-authored-by: Christian Marin <[email protected]> Co-authored-by: ZiWei Chen <[email protected]>
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.