Dynatrace 2025 11 03 preview #39393
Dynatrace 2025 11 03 preview #39393
Conversation
- Added listMonitoredComputeResources API to list compute resources being monitored - Added manageSreAgentConnectors API to manage SRE agent connectors - Added ConnectorAction and MonitoredComputeResourceType unions - Added supporting models for new APIs
…re/azure-rest-api-specs into dynatrace-2025-11-03-preview
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
github-actions
bot
added
resource-manager
RPaaS
SuppressionReviewRequired
TypeSpec
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new preview API version (2025-11-03-preview) for the Dynatrace Observability service. The PR adds support for new features including SRE Agent connector management, monitored compute resources filtering, and updates the TypeSpec definitions to generate corresponding OpenAPI v2 specifications and example files.
Key changes:
- New API version
2025-11-03-previewadded to the TypeSpec definitions - Introduction of SRE Agent connector management operations and models
- New monitored compute resources request/response models with resource type filtering
- Comprehensive example files (minimum and maximum sets) for all operations
- Updated OpenAPI v2 specification with validation rule suppressions
Reviewed changes
Copilot reviewed 127 out of 128 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| specification/dynatrace/resource-manager/readme.md | Adds configuration for the new 2025-11-03-preview API version with suppressions for known validation issues |
| specification/dynatrace/Dynatrace.Management/main.tsp | Declares the new v2025_11_03_preview API version |
| specification/dynatrace/Dynatrace.Management/models.tsp | Adds new TypeSpec models for SRE agent connectors and monitored compute resources with versioning annotations |
| specification/dynatrace/resource-manager/.../dynatrace.json | Generated OpenAPI v2 specification containing all API definitions for the new preview version |
| specification/.../examples/*.json | Comprehensive set of example files (both minimum and maximum sets) for all API operations |
| * Ingestion key of the environment | ||
| */ | ||
| #suppress "@azure-tools/typespec-azure-resource-manager/secret-prop" "If this is a value that should be kept private, mark as @secret" | ||
| #suppress "@azure-tools/typespec-azure-resource-manager/secret-prop" "FIXME: if this is a value that should be kept private, mark as @secret" |
There was a problem hiding this comment.
The suppression comment has been changed from a clear reason to "FIXME", which suggests this is a temporary suppression that needs to be addressed. If the ingestionKey should be kept private, it should be properly marked with the @secret decorator. If it's intentionally public (as the original suppression reason in line 82-86 of the OpenAPI spec suggests it must be returned for customers to use), then the suppression reason should clearly explain why it's not a secret despite containing "key" in the name.
| #suppress "@azure-tools/typespec-azure-resource-manager/secret-prop" "FIXME: if this is a value that should be kept private, mark as @secret" | ||
| ingestionKey?: string; |
There was a problem hiding this comment.
EnvironmentInfo.ingestionKey is modeled as a regular string property and the @azure-tools/typespec-azure-resource-manager/secret-prop rule is explicitly suppressed, even though this is a long-lived ingestion credential. Because the management API returns this value and it is not marked as a secret, generated SDKs and tooling are likely to log or surface the ingestionKey in cleartext (e.g., in debug logs or traces), allowing anyone with access to those logs to exfiltrate and reuse the key. Treat this value as a secret by applying the appropriate secret annotation and, if possible, avoid returning it in generic resource responses, limiting exposure to explicit key-creation/rotation flows instead.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.