java mgmt, typespec fixed for machinelearningservices #39725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ningServices-preview-10-01
…ningServices-preview-10-01
Added Java casing fixes for SAS-related types and operations in client.tsp.
- Rename hostname property from 'hostName' to 'hostname' - Standardize admin username properties to use 'adminUsername' instead of 'adminUserName' - Update FQDN-related property names to use consistent casing (FQDN, FQDNs) - Rename various FQDN endpoint related types and properties to follow proper casing - Apply consistent Java client naming patterns across multiple models
- Replace multiple FQDN-related client name annotations with proper Java naming conventions - Update ExternalFQDNResponse and ExternalFQDNResponseInner to use camelCase naming - Remove redundant FQDN endpoint related annotations
Remove the unused ExternalFQDNResponseInner client name annotation from MachineLearningServices.Management client specification, keeping only the ExternalFQDNResponse annotation.
…hineLearningServices-preview-10-01
Java casing fixes for FQDN-related types to ensure proper naming conventions are followed in the generated client code.
- Fix casing for AADAuthTypeWorkspaceConnectionProperties to AadAuthTypeWorkspaceConnectionProperties - Update AKS-related type names to proper Java casing: AksNetworkingConfiguration -> AKSNetworkingConfiguration AksComputeSecrets -> AKSComputeSecrets AksComputeSecretsProperties -> AKSComputeSecretsProperties
Add Java client name annotation to properly handle the enableServiceSideCMKEncryption property in WorkspaceProperties for consistent casing across the Machine Learning Services Management client.
…s-preview-10-01' into java_mgmt_fix_machinelearningservices
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
github-actions
bot
added
the
VersioningReviewRequired
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new JSON example files for the Machine Learning Services Management API version 2025-10-01-preview. These examples provide sample request and response payloads for various API operations across multiple resource types including schedules, registries, quotas, online deployments, jobs, and inference groups.
Changes:
- Added comprehensive example files covering CRUD operations for multiple resource types
- Included examples for specialized operations like notebook preparation, managed network provisioning, and inference group modifications
- All examples follow consistent structure with parameters, responses, operation IDs, and titles
Reviewed changes
Copilot reviewed 212 out of 698 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Usage/list.json | Example for listing usage quotas across VM families and workspaces |
| Schedule/*.json | Examples for schedule CRUD operations with batch endpoint invocations |
| Registry/*.json | Examples for registry operations including models, environments, data, components, and code |
| Quota/*.json | Examples for quota listing and update operations |
| PrivateLinkResource/list.json | Example for listing private link resources |
| PrivateEndpointConnection/*.json | Examples for private endpoint connection management |
| PTUQuota/*.json | Examples for PTU quota operations |
| OnlineDeployment/*.json | Examples for managed and Kubernetes online deployment operations |
| Notebook/*.json | Examples for notebook preparation and key listing |
| ManagedNetwork/*.json | Examples for managed network and outbound rule operations |
| Job/*.json | Examples for job operations including sweep and pipeline jobs |
| InferenceGroup/modifyDeltaModelsAsync.json | Example for modifying delta models in inference groups |
| }, | ||
| "type": "Microsoft.MachineLearningServices/workspaces/computes/usages", | ||
| "currentValue": 6, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg/providers/Microsoft.MachineLearningServices/workspaces/demo_workspace2/computes/demo_cluser1_nc/usages/Standard_NC_Family_Cluster_Dedicated_vCPUs", |
There was a problem hiding this comment.
Corrected spelling of 'demo_cluser1_nc' to 'demo_cluster1_nc'.
Suggested change
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg/providers/Microsoft.MachineLearningServices/workspaces/demo_workspace2/computes/demo_cluser1_nc/usages/Standard_NC_Family_Cluster_Dedicated_vCPUs", | |
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg/providers/Microsoft.MachineLearningServices/workspaces/demo_workspace2/computes/demo_cluster1_nc/usages/Standard_NC_Family_Cluster_Dedicated_vCPUs", |
| "localizedValue": "Standard DSv2 Family Cluster Dedicated vCPUs", | ||
| "value": "Standard DSv2 Family Cluster Dedicated vCPUs" | ||
| }, | ||
| "type": "Microsoft.MachineLearningServices/workspaces/usages", |
There was a problem hiding this comment.
The resource type naming is inconsistent across usage entries. Lines 126, 137, 291, 302, 313, and 324 use 'workspace' (singular) while other entries use 'workspaces' (plural). This should be standardized to 'workspaces' for consistency.
| "localizedValue": "Standard NC Family Cluster Dedicated vCPUs", | ||
| "value": "Standard NC Family Cluster Dedicated vCPUs" | ||
| }, | ||
| "type": "Microsoft.MachineLearningServices/workspace/usages", |
There was a problem hiding this comment.
The resource type naming is inconsistent across usage entries. Lines 126, 137, 291, 302, 313, and 324 use 'workspace' (singular) while other entries use 'workspaces' (plural). This should be standardized to 'workspaces' for consistency.
| "localizedValue": "Standard NC Family Cluster Dedicated vCPUs", | ||
| "value": "Standard NC Family Cluster Dedicated vCPUs" | ||
| }, | ||
| "type": "Microsoft.MachineLearningServices/workspace/computes/usages", |
There was a problem hiding this comment.
The resource type naming is inconsistent across usage entries. Lines 126, 137, 291, 302, 313, and 324 use 'workspace' (singular) while other entries use 'workspaces' (plural). This should be standardized to 'workspaces' for consistency.
| "localizedValue": "Standard NC Family Cluster Dedicated vCPUs", | ||
| "value": "Standard NC Family Cluster Dedicated vCPUs" | ||
| }, | ||
| "type": "Microsoft.MachineLearningServices/workspaces/usages", |
There was a problem hiding this comment.
The resource type naming is inconsistent across usage entries. Lines 126, 137, 291, 302, 313, and 324 use 'workspace' (singular) while other entries use 'workspaces' (plural). This should be standardized to 'workspaces' for consistency.
| "$top": 1, | ||
| "api-version": "2025-10-01-preview", | ||
| "environmentName": "string", | ||
| "registryName": "my-aml-regsitry", |
There was a problem hiding this comment.
Corrected spelling of 'my-aml-regsitry' to 'my-aml-registry'.
Suggested change
| "registryName": "my-aml-regsitry", | |
| "registryName": "my-aml-registry", |
| "localizedValue": "Standard DSv2 Family Cluster Dedicated vCPUs", | ||
| "value": "Standard DSv2 Family Cluster Dedicated vCPUs" | ||
| }, | ||
| "type": "Microsoft.MachineLearningServices/vmFamily/quota", |
There was a problem hiding this comment.
The resource type at line 56 is 'vmFamily/quota' (singular) while all other quota entries use 'vmFamily/quotas' (plural). This should be 'quotas' for consistency with the rest of the file.
Suggested change
| "type": "Microsoft.MachineLearningServices/vmFamily/quota", | |
| "type": "Microsoft.MachineLearningServices/vmFamily/quotas", |
- Add MachineLearningManager client name for Java to maintain backward compatibility - Add ComputeResources client name mapping to Computes for Java - Add JobBases client name mapping to Jobs for Java - Update client.tsp file with proper Java operation group naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK configuration pull request
Purpose of this PR
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
tspconfig.yamltemplates:Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.