Skip to content

Add Disk RP api-version 2026-03-02#40595

Merged
haagha merged 23 commits into
mainfrom
compute-2026-03-02
Jun 22, 2026
Merged

Add Disk RP api-version 2026-03-02#40595
haagha merged 23 commits into
mainfrom
compute-2026-03-02

Conversation

@haagha

@haagha haagha commented Feb 20, 2026

Copy link
Copy Markdown
Member

This api version update (2026-03-02) contains 3 PR's - all ARMSignedOff

#42620
#42025
#42541

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@haagha haagha marked this pull request as draft February 20, 2026 16:33
@github-actions github-actions Bot added ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed new-api-version ARMReview labels Feb 20, 2026
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/compute/armcompute
JavaScript @azure/arm-compute
Python azure-mgmt-compute
TypeSpec ComputeDisk
Swagger Microsoft.Compute-Compute
Java com.azure.resourcemanager:azure-resourcemanager-compute
C# Azure.ResourceManager.Compute

Comment generated by After APIView workflow run.

Haider Agha and others added 3 commits April 8, 2026 16:27
The DiskRP.json swagger had incorrect relative  paths using
'../../../common-types/v1/common.json' (3 levels up) which resolves to
a non-existent 'Microsoft.Compute/common-types/' path. Fixed to use
'../../common-types/v1/common.json' (2 levels up) matching the correct
'Compute/common-types/' location, consistent with other DiskRP versions.
@github-actions github-actions Bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-JavaScript-Sdk labels Apr 8, 2026
@github-actions github-actions Bot removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 20, 2026
Haider Agha and others added 3 commits April 23, 2026 12:27
…ss (#42620) (ARM Approved)

Added snapshotAccessState property to DiskRestorePointProperties in TypeSpec
and generated OpenAPI spec for API version 2026-03-02. This property already
exists on SnapshotProperties. The SnapshotAccessState enum already exists in
common/models.tsp — no new types needed.

Co-authored-by: NORTHAMERICA\akashpargat <akashpargat@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@psah434 psah434 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 26, 2026
@haagha haagha added Approved-Avocado WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels May 29, 2026

@ravimeda ravimeda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (critic-verified, 2 iterations, converged) against commit 8e92932. See inline comments for findings 1-2.

@ravimeda ravimeda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (critic-verified, 2 iterations, converged) against commit 8e92932. See inline comments for findings 1-2.

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2026
@zhanrz88-sudo zhanrz88-sudo mentioned this pull request Jun 8, 2026
@haagha haagha added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jun 16, 2026
@gary-x-li

Copy link
Copy Markdown
Contributor

Please resolve merge conflict and address this comment

@gary-x-li gary-x-li added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2026
@haagha haagha added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jun 18, 2026
@gary-x-li gary-x-li added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-Suppression and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 18, 2026
@haagha haagha added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jun 18, 2026
@haagha haagha merged commit a9ae4ad into main Jun 22, 2026
42 of 43 checks passed
@haagha haagha deleted the compute-2026-03-02 branch June 22, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Compute new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants