Add ARM lease files for all resource providers (405 RPs)#42454
Merged
Conversation
- 405 lease files across main branch and RPSaaSMaster-only RPs - Staggered durations (P30D-P180D) in 6 cohorts to spread review load - Reviewer: @vikeshi26, startdate: 2026-04-28 - Distribution: P30D(50), P60D(71), P90D(71), P120D(71), P150D(71), P180D(71) - Add temp RP inventory files to .gitignore
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
mikeharder
requested changes
Apr 17, 2026
Member
There was a problem hiding this comment.
I'm getting concerned about the number of files we're adding to the repo here. I did approve the original design, but I thought the number of files would be lower, or more gradually added/removed.
Seeing this number of files, I think we should instead move to a single file arm-leases.yaml, with the same lease contents, just in a single file rather than 406 files. Or some other design that's easier to manage than 406 files in nested folders.
CC: @tejaswiMinnu, @weshaggard
mikeharder
reviewed
Apr 17, 2026
| @@ -139,6 +139,12 @@ eng/tools/**/dist | |||
| !/.github/package-lock.json | |||
| !/.github/shared/package-lock.json | |||
|
|
|||
| # Temp RP inventory files | |||
Member
There was a problem hiding this comment.
please revert this, you can store the files outside the repo locally
Member
mikeharder
requested changes
Apr 21, 2026
…re are already existing uppercase orgnames
…re are already existing uppercase orgnames
ab50479 to
5de4c27
Compare
mikeharder
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds ARM lease files for 405 resource providers covering all RPs across:
Lease Configuration
Other Changes
.gitignore: Added temp RP inventory files (rps-no-groups.txt,rps-with-groups.txt,rps-pr-repo.txt,groups.txt)