Skip to content

Add ARM lease files for all resource providers (405 RPs)#42454

Merged
tejaswiMinnu merged 14 commits into
Azure:mainfrom
vikeshi26:vikeshi26/arm-lease-files
Apr 28, 2026
Merged

Add ARM lease files for all resource providers (405 RPs)#42454
tejaswiMinnu merged 14 commits into
Azure:mainfrom
vikeshi26:vikeshi26/arm-lease-files

Conversation

@vikeshi26

Copy link
Copy Markdown
Member

Summary

Adds ARM lease files for 405 resource providers covering all RPs across:

  • Main branch (98 no-group RPs + 255 service-group RPs)
  • RPSaaSMaster-only RPs (54 private RPs)

Lease Configuration

  • Reviewer: @vikeshi26
  • Start date: 2026-04-28
  • Durations: Staggered across 6 cohorts to spread review load evenly:
Cohort Duration Count Expiry
1 P30D 50 May 28
2 P60D 71 Jun 27
3 P90D 71 Jul 27
4 P120D 71 Aug 26
5 P150D 71 Sep 25
6 P180D 71 Oct 25

Other Changes

  • .gitignore: Added temp RP inventory files (rps-no-groups.txt, rps-with-groups.txt, rps-pr-repo.txt, groups.txt)

- 405 lease files across main branch and RPSaaSMaster-only RPs
- Staggered durations (P30D-P180D) in 6 cohorts to spread review load
- Reviewer: @vikeshi26, startdate: 2026-04-28
- Distribution: P30D(50), P60D(71), P90D(71), P120D(71), P150D(71), P180D(71)
- Add temp RP inventory files to .gitignore
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@mikeharder mikeharder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting concerned about the number of files we're adding to the repo here. I did approve the original design, but I thought the number of files would be lower, or more gradually added/removed.

Seeing this number of files, I think we should instead move to a single file arm-leases.yaml, with the same lease contents, just in a single file rather than 406 files. Or some other design that's easier to manage than 406 files in nested folders.

CC: @tejaswiMinnu, @weshaggard

Comment thread .gitignore Outdated
@@ -139,6 +139,12 @@ eng/tools/**/dist
!/.github/package-lock.json
!/.github/shared/package-lock.json

# Temp RP inventory files

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this, you can store the files outside the repo locally

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

@mikeharder

Copy link
Copy Markdown
Member

Based on the checks in this PR, these 409 lease files don't appear to be impacting checkout perf. So while I still think it would be better to refactor them into a single file, I'm fine with merging them as-is for now.

One error you will need to fix, prettier is failing because you have invalid yaml:

image

Reviewer name needs to be quoted. In the widget example, startdate is also quoted, but I'm not sure if that's necessary or optional.

@mikeharder mikeharder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix prettier errors in yaml files. At a minimum, reviewer names starting with "@" need to be quoted. We should also require trailing newlines -- i think prettier requires this by default, and it might flag after you quote the reviewer names.

@tejaswiMinnu tejaswiMinnu force-pushed the vikeshi26/arm-lease-files branch from ab50479 to 5de4c27 Compare April 28, 2026 22:03
@tejaswiMinnu tejaswiMinnu enabled auto-merge (squash) April 28, 2026 23:28
@tejaswiMinnu tejaswiMinnu disabled auto-merge April 28, 2026 23:28
@tejaswiMinnu tejaswiMinnu merged commit 413f958 into Azure:main Apr 28, 2026
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants