Add lease files correctly#42863
Merged
Merged
Conversation
tejaswiMinnu
requested review from
benbp,
mikeharder and
weshaggard
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
AkhilaIlla
reviewed
May 4, 2026
Member
There was a problem hiding this comment.
Is the lease file for this RP in a different folder?
Member
Author
There was a problem hiding this comment.
yes, this is service level lease
| throw new Error(`orgName must be lowercase alphanumeric: ${orgName}`); | ||
| const normalized = orgName.toLowerCase(); | ||
| if (!/^[a-z0-9-]+$/.test(normalized)) { | ||
| throw new Error(`orgName must be lowercase alphanumeric (hyphens allowed): ${orgName}`); |
Member
There was a problem hiding this comment.
are you already not updating the org to lower case?
Member
Author
There was a problem hiding this comment.
I am, just renamed properly and updated error message
AkhilaIlla
approved these changes
May 6, 2026
mikeharder
approved these changes
May 6, 2026
saprakas
pushed a commit
to iyyappam/azure-rest-api-specs
that referenced
this pull request
May 12, 2026
* Add lease files * cohorts 120/180 days * format * prettier check * Prettier check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous lease files added by Vikeshi was not correct, altering the folder structure for Rp's with and without service names