Skip to content

Add ARM lease metadata for Microsoft.Offers/Offers (P120D)#42996

Merged
tejaswiMinnu merged 1 commit into
mainfrom
copilot/add-lease-yaml-for-offers
May 7, 2026
Merged

Add ARM lease metadata for Microsoft.Offers/Offers (P120D)#42996
tejaswiMinnu merged 1 commit into
mainfrom
copilot/add-lease-yaml-for-offers

Conversation

Copilot AI commented May 7, 2026

Copy link
Copy Markdown
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

Adds the missing ARM lease metadata file for offers/Microsoft.Offers/Offers to satisfy lease ownership requirements with a 120-day lease window and assigned reviewer.

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Add ARM lease metadata under .github/arm-leases/offers/Microsoft.Offers/Offers/lease.yaml for an existing RP/subservice path.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

  • Change summary
    • Added one new lease file at .github/arm-leases/offers/Microsoft.Offers/Offers/lease.yaml.
  • Lease content
    • resource-provider: Microsoft.Offers
    • startdate: 2026-05-07
    • duration: P120D
    • reviewer: @tejaswiMinnu
lease:
  resource-provider: Microsoft.Offers
  startdate: "2026-05-07"
  duration: P120D
  reviewer: "@tejaswiMinnu"
Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@tejaswiMinnu tejaswiMinnu enabled auto-merge (squash) May 7, 2026 22:09
lease:
resource-provider: Microsoft.Offers
startdate: "2026-05-07"
duration: P120D

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is the duration determined?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random - New RP's 120 or 90 days

@tejaswiMinnu tejaswiMinnu disabled auto-merge May 7, 2026 22:43
@tejaswiMinnu tejaswiMinnu merged commit b133caa into main May 7, 2026
40 of 48 checks passed
@tejaswiMinnu tejaswiMinnu deleted the copilot/add-lease-yaml-for-offers branch May 7, 2026 22:43
saprakas pushed a commit to iyyappam/azure-rest-api-specs that referenced this pull request May 12, 2026
…e#42996)

Agent-Logs-Url: https://github.com/Azure/azure-rest-api-specs/sessions/009fd112-0335-481a-969e-5c04d2470f4c

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tejaswiMinnu <14865963+tejaswiMinnu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants