Skip to content

AKS Fleet 2026-06-02-preview API version#43386

Open
minhng22 wants to merge 21 commits into
mainfrom
dev-aks-fleet-2026-06-02-preview
Open

AKS Fleet 2026-06-02-preview API version#43386
minhng22 wants to merge 21 commits into
mainfrom
dev-aks-fleet-2026-06-02-preview

Conversation

@minhng22

@minhng22 minhng22 commented May 20, 2026

Copy link
Copy Markdown
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMModelingAutoSignedOff ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ContainerService-fleet
TypeSpec Microsoft.ContainerService
Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet
JavaScript @azure/arm-containerservicefleet
Python azure-mgmt-containerservicefleet
Java com.azure.resourcemanager:azure-resourcemanager-containerservicefleet

Comment generated by After APIView workflow run.

@github-actions github-actions Bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Go-Sdk NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 20, 2026
@minhng22 minhng22 requested a review from Copilot May 21, 2026 16:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@minhng22 minhng22 removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels May 21, 2026
@github-actions github-actions Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2026
@minhng22

minhng22 commented May 21, 2026

Copy link
Copy Markdown
Member Author

No change from PR #41422 (which is signed off) beside #42756

Closed #42755 since we want to publis 0602preview instead of 0601preview

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Sean Hobbs and others added 6 commits May 22, 2026 12:01
Co-authored-by: Sean Hobbs <sehobbs@microsoft.com>
* add memberselector to updatestage ts

* update tspconfig to reference examples-dir

* add examples/2026-05-01-preview dir

* update 2026-05-01-preview/examples

* tsp compile

---------

Co-authored-by: yoobinshin <yoobinshin@microsoft.com>
… Staged Update Run and enhance PATCH for Managed Namespace (#41809)
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels May 26, 2026
@minhng22 minhng22 force-pushed the dev-aks-fleet-2026-06-02-preview branch from b23f52f to b3ee07b Compare May 26, 2026 19:56
@github-actions github-actions Bot added ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 26, 2026
@minhng22 minhng22 force-pushed the dev-aks-fleet-2026-06-02-preview branch 3 times, most recently from 400f4d4 to eeff4c9 Compare May 28, 2026 23:35
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 28, 2026
@minhng22 minhng22 force-pushed the dev-aks-fleet-2026-06-02-preview branch from eeff4c9 to 3846603 Compare May 28, 2026 23:51
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels May 28, 2026
@minhng22 minhng22 force-pushed the dev-aks-fleet-2026-06-02-preview branch from 3846603 to dec971e Compare May 29, 2026 00:08
@github-actions github-actions Bot added ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2026
@ravimeda

Copy link
Copy Markdown
Member

ARM review: scope clarification needed before line-level review

This PR introduces two new preview API versions in a single change:

  • preview/2026-05-01-preview/ (new fleets.json, full example set)
  • preview/2026-06-02-preview/ (new fleets.json, full example set)

Plus a parallel top-level examples/2026-05-01-preview/ and examples/2026-06-02-preview/ tree that duplicates the per-version examples/ folders.

Several of your replies on existing review comments (e.g., on FleetMembers_ListByFleet.json, UpdateStrategies_Delete.json, AutoUpgradeProfileOperations_GenerateUpdateRun.json, ClusterMeshProfiles_ListByFleet.json, gate.tsp) say "not this api version. active PR https://github.com/Azure/azure-rest-api-specs/pull/41422/changes", which suggests 2026-05-01-preview is owned by PR #41422 and was pulled into this branch by a merge/rebase rather than intentionally.

Before doing a full ARM review, could you confirm the intended scope of this PR?

  1. Is AKS Fleet 2026-06-02-preview API version #43386 meant to introduce only 2026-06-02-preview, with 2026-05-01-preview being collateral from rebasing on AKS Fleet 2026-05-01-preview API version #41422? If so, please rebase to drop the 2026-05-01-preview files from this PR''s diff so review focuses on the right surface.
  2. Are the duplicate top-level examples/2026-05-01-preview/ and examples/2026-06-02-preview/ directories intentional, or should examples live only under preview/<version>/examples/? The duplicate path is not standard ARM layout and risks AutoRest picking up the wrong copy.
  3. Per uniform-versioning, please confirm two new preview versions in one PR is intentional rather than splitting into separate PRs.

Once scope is settled I will run the full ARM review on the correct surface.

@minhng22

Copy link
Copy Markdown
Member Author

ARM review: scope clarification needed before line-level review

This PR introduces two new preview API versions in a single change:

  • preview/2026-05-01-preview/ (new fleets.json, full example set)
  • preview/2026-06-02-preview/ (new fleets.json, full example set)

Plus a parallel top-level examples/2026-05-01-preview/ and examples/2026-06-02-preview/ tree that duplicates the per-version examples/ folders.

Several of your replies on existing review comments (e.g., on FleetMembers_ListByFleet.json, UpdateStrategies_Delete.json, AutoUpgradeProfileOperations_GenerateUpdateRun.json, ClusterMeshProfiles_ListByFleet.json, gate.tsp) say "not this api version. active PR https://github.com/Azure/azure-rest-api-specs/pull/41422/changes", which suggests 2026-05-01-preview is owned by PR #41422 and was pulled into this branch by a merge/rebase rather than intentionally.

Before doing a full ARM review, could you confirm the intended scope of this PR?

  1. Is AKS Fleet 2026-06-02-preview API version #43386 meant to introduce only 2026-06-02-preview, with 2026-05-01-preview being collateral from rebasing on AKS Fleet 2026-05-01-preview API version #41422? If so, please rebase to drop the 2026-05-01-preview files from this PR''s diff so review focuses on the right surface.
  2. Are the duplicate top-level examples/2026-05-01-preview/ and examples/2026-06-02-preview/ directories intentional, or should examples live only under preview/<version>/examples/? The duplicate path is not standard ARM layout and risks AutoRest picking up the wrong copy.
  3. Per uniform-versioning, please confirm two new preview versions in one PR is intentional rather than splitting into separate PRs.

Once scope is settled I will run the full ARM review on the correct surface.

Thank you for the review.

Response to your (1) and (3): As the description of the PR, the intention is only to add 2026-06-02-preview API version. Active PR to add 2026-05-01-preview API version is #41422
Once that PR is merged, we will rebase the changes into this PR.

Response to your (2): That structure is intentional and that is a structure that has been there for years. The examples is also auto-generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff-IncrementalTSP ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Container Service new-api-version resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants