-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix SecurityInsights Swagger breaking-change compatibility regressions #43548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdiMegid
wants to merge
39
commits into
main
Choose a base branch
from
securityinsights-add-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93,816
−17,601
Open
Changes from 34 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
4d214d6
Add Versions enum and decorate preview-only resource files
0ef3151
Decorate preview-only declarations in models.tsp
c302e64
Fix Entity versioning
717342f
Versioning models.tsp
AdiMegid 2807478
Versioning AlertRule, Bookmark, DataConnector, routes, Relation
AdiMegid 75d3f7c
Add 'using TypeSpec.Versioning;' to files using @added
AdiMegid 7c5dba9
Add openapi.json + examples for 2025-09-01 and 2025-10-01-preview
AdiMegid a39610d
Switch stable/2025-09-01 to single openapi.json; delete split files a…
AdiMegid 4e19e03
Add tag package-preview-2025-10-01 to readme
AdiMegid 5595a63
Revert AATP/MCAS/MDATP/MSTI model names to PascalCase to fix casing-s…
AdiMegid 2f96edc
Run tsp format (remove trailing blank line in Entity.tsp)
AdiMegid 74886e6
Fix api-version in 2025-10-01-preview examples
AdiMegid 93c91e4
Restore stable/2025-09-01/common/1.0/types.json (pre-existing orphan)
AdiMegid 4d3220a
Fix Incidents_RunPlaybook 204 response: remove unknown body
AdiMegid 831d9ed
Revert "Fix Incidents_RunPlaybook 204 response: remove unknown body"
AdiMegid 3cd360a
Add 204 body to stable Incidents_RunPlaybook example to match spec
AdiMegid 2b63a61
Preserve SecurityInsights schema compatibility
Copilot 58c1b44
Revert last commit (TSP schema changes)
AdiMegid d373ecb
Fix Watchlist headers
AdiMegid 0251220
Add 204 body to Incidents_RunPlaybook example to match schema
AdiMegid 3594f6b
fix headers
AdiMegid 7c5a495
fix required status changes for Package/Template/ScheduledAlertRule m…
AdiMegid ee5350a
fix required status for ScheduledAlertRuleCommonProperties and Page<T…
AdiMegid 6ab0a97
fix x-ms-enum names for flag and triggerWhen
AdiMegid 36d5580
fix x-ms-enum names
AdiMegid f09a2a9
fix x-ms-enum names for (MetadataDependencyOperator, PullRequestState…
AdiMegid 3a227ef
add readOnly to nextLink properties
AdiMegid 0bd9522
restore package base props to PackageBaseProperties
AdiMegid 2a1c198
Revert "restore package base props to PackageBaseProperties"
AdiMegid b03a0c5
rename metadataDependencies kind enum to metadataKind
AdiMegid 88dd614
revert metadataKind rename
AdiMegid 436da14
revert required status changes for Package/Template
AdiMegid f982b7d
fix typeSpec validation
AdiMegid 6ea8fae
fix Java SDK build: remove ScheduledAlertRuleProperties required rede…
AdiMegid dd8c91e
Remove redundant supressions
guywilfshukrun-msft 527a9cb
remove supress
guywilfshukrun-msft 501915e
Merge branch 'main' into securityinsights-add-versions
guywilfshukrun a09c389
revert camelcase to pascalcase
guywilfshukrun-msft cf0ca45
fix PascalCase
guywilfshukrun-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we add finalresult to a delete operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an async operation same as we have with createOrReplace few lines above
We did the change because the RetryAfterHeaders is not supported in the BE for this operation