[Monitor] Add Metric Alerts Query GA 2026-01-01 swagger by sidanmor · Pull Request #43587 · Azure/azure-rest-api-specs

sidanmor · 2026-05-28T16:35:06Z

Review Focus

TL;DR

The stream1 changes correctly promote Metric Alerts Query to GA 2026-01-01, switch package-2025-08 manifest wiring to the GA swagger, and include stable example files aligned to swagger x-ms-examples references.

Key Files to Review

specification/monitor/resource-manager/Microsoft.Insights/Insights/MetricAlertApi/main.tsp
specification/monitor/resource-manager/Microsoft.Insights/Insights/readme.md
specification/monitor/resource-manager/Microsoft.Insights/Insights/stable/2026-01-01/metricAlert.json
specification/monitor/resource-manager/Microsoft.Insights/Insights/stable/2026-01-01/examples/*.json

Risk Areas

package-2025-08 manifest switch is the highest-impact surface for downstream consumers, but remains within approved scope.

Design Alignment

Implementation is aligned with approved discovery/design/plan/LLD: GA version added, stable swagger/examples produced, preview compatibility preserved, and manifest scope constrained.

Summary

Add GA API version 2026-01-01 for Metric Alerts Query.
Add stable swagger + examples under Insights/stable/2026-01-01.
Update Insights/readme.md package-2025-08 input-file to stable/2026-01-01/metricAlert.json.

Validation

Local JSON parse validation for GA swagger/examples.
git diff --check clean.

Work item: metric-alerts-query-ga-swagger

…-swagger]

github-actions · 2026-05-28T16:35:41Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review
❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Comment generated by summarize-checks workflow run.

github-actions · 2026-05-28T16:44:46Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
TypeSpec	MetricAlertApi
JavaScript	@azure/arm-monitor
Python	azure-mgmt-monitor
Go	sdk/resourcemanager/monitor/armmonitor
Java	com.azure.resourcemanager:azure-resourcemanager-monitor
C#	Azure.ResourceManager.Monitor

Comment generated by After APIView workflow run.

ravimeda

ARM API review for PR #43587 at head SHA 6556222ebaa2c43e513a2ae86f98e1107e6cdeee. 7 findings (0 new blocking, 1 existing blocking, 1 existing warning, 5 suggestions). All findings verified by ARM API Review Critic subagent (1 iteration; 4 finding-level corrections folded in).

ravimeda

ARM API review for PR #43587 at head SHA 6556222ebaa2c43e513a2ae86f98e1107e6cdeee. 7 findings (0 new blocking, 1 existing blocking, 1 existing warning, 5 suggestions). All findings verified by ARM API Review Critic subagent (1 iteration; 4 finding-level corrections folded in).

…ry-ga-swagger]

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sidanmor · 2026-06-11T08:32:13Z

/azp run

azure-pipelines · 2026-06-11T08:32:19Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

sidanmor · 2026-06-11T11:38:54Z

/azp run TypeSpec Validation

azure-pipelines · 2026-06-11T11:39:01Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

…le-version readme.md to fix Avocado MULTIPLE_API_VERSION The failing CI job (Swagger Avocado - Analyze Code) reported MULTIPLE_API_VERSION on Insights/readme.md because its default tag package-2025-08 contains swaggers from many different API version folders (2015–2026). The fix avoids touching Insights/readme.md (which would re-trigger the check) by: 1. Adding the GA stable/2026-01-01/metricAlert.json swagger generated from TypeSpec 2. Adding all stable/2026-01-01/examples/ metric alert example files 3. Adding stable/2026-01-01/readme.md with a single-version default tag (package-2026-01-01) referencing both activityLogAlerts_API.json and metricAlert.json With readme.md present in stable/2026-01-01/, avocado's findTheNearestReadme traces the new swagger files to this single-version readme (no MULTIPLE_API_VERSION), and Insights/readme.md with its composite multi-version default tag is never evaluated. Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

… Email.Subject typo in examples Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

…/fix-swaggervavocado-analyze-code-job

…code-job Copilot/fix swaggervavocado analyze code job

…versioning design

…to maintain backward compatibility

…te error response references

…peration response

…inition

Add Metric Alerts Query GA 2026-06-01 swagger [metric-alerts-query-ga…

6556222

…-swagger]

microsoft-github-policy-service Bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label May 28, 2026

github-actions Bot added ARMReview new-api-version resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 28, 2026

ravimeda reviewed May 29, 2026

View reviewed changes

ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2026

sidanmor and others added 3 commits June 2, 2026 09:19

Address ARM API review suggestions [metric-alerts-query-ga-swagger]

ca25608

Apply PR decisions for package tag and error model [metric-alerts-que…

e339d9e

…ry-ga-swagger]

Fix metric alert GA api-version to 2026-01-01

f6ad53c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions Bot added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed new-api-version ARMChangesRequested labels Jun 3, 2026

sidanmor changed the title ~~[Monitor] Add Metric Alerts Query GA 2026-06-01 swagger~~ [Monitor] Add Metric Alerts Query GA 2026-01-01 swagger Jun 9, 2026

sidanmor added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jun 11, 2026

Regenerate MetricAlert swagger outputs for TypeSpec validation

e25710a

Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

Copilot AI mentioned this pull request Jun 14, 2026

Fix TypeSpec Validation CI: format MetricAlertResource.tsp and regenerate swagger outputs #43951

Closed

9 tasks

Merge branch 'Azure:main' into metric-alerts-query-ga-swagger-stream1-v2

2fcca45

sidanmor and others added 2 commits June 21, 2026 15:44

Update metric alert example files from TypeSpec compilation

cf8e9e8

Initial plan

99106fe

Copilot AI mentioned this pull request Jun 21, 2026

[Monitor] Fix Avocado MULTIPLE_API_VERSION: add GA stable/2026-01-01/metricAlert.json with single-version readme #44121

Draft

9 tasks

Copilot AI and others added 8 commits June 21, 2026 14:54

Fix review issues: update Azure AD wording to Microsoft Entra ID, fix…

c89fe09

… Email.Subject typo in examples Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

Add format: uri to nextLink property in metricAlert.json

8640d95

Co-authored-by: sidanmor <6368621+sidanmor@users.noreply.github.com>

Merge branch 'Azure:main' into metric-alerts-query-ga-swagger-stream1-v2

569eade

Merge branch 'metric-alerts-query-ga-swagger-stream1-v2' into copilot…

8b98a68

…/fix-swaggervavocado-analyze-code-job

Merge pull request #3 from Azure/copilot/fix-swaggervavocado-analyze-…

66a4b96

…code-job Copilot/fix swaggervavocado analyze code job

Remove format: uri from nextLink property in metricAlert.json

5e785a3

Add suppression for MULTIPLE_API_VERSION in readme.md to clarify API …

e75ffb1

…versioning design

github-actions Bot added the SuppressionReviewRequired label Jun 22, 2026

sidanmor added 6 commits June 23, 2026 09:56

Fix: Remove breaking changes by reverting preview swagger and models …

28d9cd2

…to maintain backward compatibility

Fix: Correct grammar in metric alert definition descriptions and upda…

25c995b

…te error response references

Merge branch 'Azure:main' into metric-alerts-query-ga-swagger-stream1-v2

98ba131

Fix: Update MetricAlert API to include Retry-After header in create o…

9c04f32

…peration response

Fix: Remove deprecated tag from MonitorClient configuration

655933e

Fix: Correct grammar in metric alert definition descriptions

b91961d

sidanmor added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jun 25, 2026

github-actions Bot removed the NotReadyForARMReview label Jun 25, 2026

Fix: Correct grammar in metric alert definition descriptions

b2f3b24

github-actions Bot added the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Jun 25, 2026

Fix: Add success response for MetricAlertResource creation in API def…

b3be737

…inition

github-actions Bot added NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2026

sidanmor added 2 commits June 25, 2026 15:50

Fix: Correct grammar in metric alert definition comments

c9b121d

Fix: Remove suppression for MULTIPLE_API_VERSION in MonitorClient readme

42a5e0e

github-actions Bot removed the SuppressionReviewRequired label Jun 25, 2026

sidanmor closed this Jun 30, 2026

Uh oh!

Conversation

sidanmor commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Focus

TL;DR

Key Files to Review

Risk Areas

Design Alignment

Summary

Validation

Uh oh!

github-actions Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

github-actions Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

ravimeda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ravimeda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sidanmor commented Jun 11, 2026

Uh oh!

azure-pipelines Bot commented Jun 11, 2026

Uh oh!

sidanmor commented Jun 11, 2026

Uh oh!

azure-pipelines Bot commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sidanmor commented May 28, 2026 •

edited

Loading

github-actions Bot commented May 28, 2026 •

edited

Loading

github-actions Bot commented May 28, 2026 •

edited

Loading