Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments#43606
Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments#43606bgriddaluru wants to merge 52 commits into
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
ravimeda
left a comment
There was a problem hiding this comment.
ARM API Review
Posting findings from automated ARM API review (critic-verified, 2 iterations, converged). See inline comments for findings 3-12. The two issues below concern files not in the PR diff and are posted here.
🔴 Blocking #1 — [NEW] Generated swagger missing
File: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/kubeInventory/preview/2026-06-15-preview/kubeInventory.json — not present at head SHA
Issue: kubeInventory/tspconfig.yaml line 10 declares output-file: "{version-status}/{version}/kubeInventory.json", but no generated swagger is checked in (404 at both kubeInventory/preview/2026-06-15-preview/ and the parent preview/2026-06-15-preview/). ARM TypeSpec projects MUST commit the emitted swagger alongside the .tsp source so AutoRest, SDK generation, and ARM manifest validation can consume it.
Fix: Run tsp compile . in the kubeInventory/ directory and commit the produced kubeInventory.json plus all referenced example files at their final swagger-relative paths.
🔴 Blocking #2 — [NEW] readme.md not updated
File: specification/kubernetesconfiguration/resource-manager/readme.md — not modified in this PR
Issue: A new API version and a new input file are being added, but the service readme.md has no new tag: block and no updated input-file: list referencing the new kubeInventory.json. The new surface will not be processed by AutoRest or any SDK generation pipeline.
Fix: Add a tag (e.g., package-2026-06-15-preview-kubeinventory) listing the new input file; update the default tag: selector if appropriate.
PR title note: 2026-06-16-preview in the PR title but spec/folder/examples use 2026-06-15-preview. Likely a typo to correct before merge.
dipti-pai
left a comment
There was a problem hiding this comment.
@bgriddaluru FYI, you will need to update the operations folder to add this new API version. Sharing a link to the comment where this decision was made when the monolithic KubernetesConfiguration service was broken into suite of services model - #31523 (comment)
Add 2026-06-15-preview API version for Microsoft.KubernetesConfiguration to add KubernetesResources and UpgradeAssessments