Remove stale Microsoft.DBforPostgreSQL/PostgreSQL/ ARM lease (case-collision fix; supersedes #43887)#43889
Merged
tejaswiMinnu merged 1 commit intoJun 10, 2026
Conversation
…llision fix) Removes .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml which case-collides with the sibling PostgreSql/lease.yaml on Windows/macOS filesystems and is no longer referenced by the spec layout. The lowercase PostgreSql/ folder matches the service folder casing introduced by https://github.com/Azure/azure-rest-api-specs-pr/pull/28858 / Azure#43777 (postgresql folder restructure), so keeping PostgreSql/ preserves lease coverage for that PR while eliminating the case-only duplicate. Supersedes Azure#43887, which removed the lowercase variant; removing the lowercase one would re-trigger ARMModelingReviewRequired on the partner restructure PR because the lease checker looks up the exact-cased path.
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
timotheeguerin
approved these changes
Jun 10, 2026
tejaswiMinnu
approved these changes
Jun 10, 2026
glecaros
pushed a commit
to daniel-rodrigues809/azure-rest-api-specs
that referenced
this pull request
Jun 17, 2026
…llision fix) (Azure#43889) Removes .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml which case-collides with the sibling PostgreSql/lease.yaml on Windows/macOS filesystems and is no longer referenced by the spec layout. The lowercase PostgreSql/ folder matches the service folder casing introduced by Azure/azure-rest-api-specs-pr#28858 / Azure#43777 (postgresql folder restructure), so keeping PostgreSql/ preserves lease coverage for that PR while eliminating the case-only duplicate. Supersedes Azure#43887, which removed the lowercase variant; removing the lowercase one would re-trigger ARMModelingReviewRequired on the partner restructure PR because the lease checker looks up the exact-cased path. Co-authored-by: Vikeshi Tiwari <vikestiwari@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
.github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yamlwhich case-collides with siblingPostgreSql/lease.yamlon Windows/macOS filesystems and is no longer referenced by the spec layout.Context
PR #43785 added a
PostgreSql/lease.yaml(lowercasel) to accompany the in-flight postgres folder restructure in https://github.com/Azure/azure-rest-api-specs-pr/pull/28858 (a.k.a. #43777, "Refactor(postgresql): migrate to unified folder structure"), which usesPostgreSqlas the service folder name. We did not notice at the time that a siblingPostgreSQL/lease.yaml(uppercaseSQL) already existed under the same RP.Both folders coexist fine on Linux git, but Windows/macOS case-insensitive filesystems can only materialize one of them, producing phantom
M …/PostgreSQL/lease.yaml(or…/PostgreSql/lease.yaml) entries ingit statusfor any contributor on those platforms after a clone/pull.Decision
There is currently no service-named folder under
specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/(onlypreview/andstable/exist onmain), so neither casing is in active use today. The in-flight restructure PR #43777 introduces the service folder asPostgreSql/(lowercase l), and the lease checker in.github/workflows/src/arm-modeling-review/detect-arm-leases.jsuses the exact-cased path — so thePostgreSql/lease is the one needed for that partner PR to clearARMModelingReviewRequired. The uppercasePostgreSQL/lease, by contrast, does not match any spec folder that exists or is about to exist.Therefore:
.github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSql/lease.yaml(matches partner restructure casing).github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml(stale, case-only duplicate)Relationship to #43887
This supersedes #43887 by @timotheeguerin. That PR removes the lowercase
PostgreSql/variant; doing so would re-triggerARMModelingReviewRequiredon #43777 because the lookup path is case-sensitive and the remaining uppercasePostgreSQL/lease would not be found at the partner-introducedPostgreSql/path. Suggest closing #43887 in favor of this PR.Verification
cc @timotheeguerin @tejaswiMinnu @mikeharder