Skip to content

Remove stale Microsoft.DBforPostgreSQL/PostgreSQL/ ARM lease (case-collision fix; supersedes #43887)#43889

Merged
tejaswiMinnu merged 1 commit into
Azure:mainfrom
vikeshi26:vikeshi26/arm-lease-postgresql-remove-uppercase
Jun 10, 2026
Merged

Remove stale Microsoft.DBforPostgreSQL/PostgreSQL/ ARM lease (case-collision fix; supersedes #43887)#43889
tejaswiMinnu merged 1 commit into
Azure:mainfrom
vikeshi26:vikeshi26/arm-lease-postgresql-remove-uppercase

Conversation

@vikeshi26

Copy link
Copy Markdown
Member

Removes .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml which case-collides with sibling PostgreSql/lease.yaml on Windows/macOS filesystems and is no longer referenced by the spec layout.

Context

PR #43785 added a PostgreSql/lease.yaml (lowercase l) to accompany the in-flight postgres folder restructure in https://github.com/Azure/azure-rest-api-specs-pr/pull/28858 (a.k.a. #43777, "Refactor(postgresql): migrate to unified folder structure"), which uses PostgreSql as the service folder name. We did not notice at the time that a sibling PostgreSQL/lease.yaml (uppercase SQL) already existed under the same RP.

Both folders coexist fine on Linux git, but Windows/macOS case-insensitive filesystems can only materialize one of them, producing phantom M …/PostgreSQL/lease.yaml (or …/PostgreSql/lease.yaml) entries in git status for any contributor on those platforms after a clone/pull.

Decision

There is currently no service-named folder under specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/ (only preview/ and stable/ exist on main), so neither casing is in active use today. The in-flight restructure PR #43777 introduces the service folder as PostgreSql/ (lowercase l), and the lease checker in .github/workflows/src/arm-modeling-review/detect-arm-leases.js uses the exact-cased path — so the PostgreSql/ lease is the one needed for that partner PR to clear ARMModelingReviewRequired. The uppercase PostgreSQL/ lease, by contrast, does not match any spec folder that exists or is about to exist.

Therefore:

  • Keep: .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSql/lease.yaml (matches partner restructure casing)
  • Remove (this PR): .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml (stale, case-only duplicate)

Relationship to #43887

This supersedes #43887 by @timotheeguerin. That PR removes the lowercase PostgreSql/ variant; doing so would re-trigger ARMModelingReviewRequired on #43777 because the lookup path is case-sensitive and the remaining uppercase PostgreSQL/ lease would not be found at the partner-introduced PostgreSql/ path. Suggest closing #43887 in favor of this PR.

Verification

git ls-tree -r origin/main .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/
# PostgreSql/lease.yaml      ← kept (matches #43777 spec folder casing)
# PostgreSQL/lease.yaml      ← removed by this PR
# DBforPostgreSQL/lease.yaml ← unrelated, kept
# lease.yaml                 ← unrelated, kept

git ls-tree -d origin/main specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/
# preview/  stable/   (no service folder today)

cc @timotheeguerin @tejaswiMinnu @mikeharder

…llision fix)

Removes .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml
which case-collides with the sibling PostgreSql/lease.yaml on Windows/macOS
filesystems and is no longer referenced by the spec layout. The lowercase
PostgreSql/ folder matches the service folder casing introduced by
https://github.com/Azure/azure-rest-api-specs-pr/pull/28858 / Azure#43777
(postgresql folder restructure), so keeping PostgreSql/ preserves lease
coverage for that PR while eliminating the case-only duplicate.

Supersedes Azure#43887, which removed the lowercase variant; removing the lowercase
one would re-trigger ARMModelingReviewRequired on the partner restructure PR
because the lease checker looks up the exact-cased path.
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@tejaswiMinnu tejaswiMinnu merged commit 9929210 into Azure:main Jun 10, 2026
46 of 48 checks passed
glecaros pushed a commit to daniel-rodrigues809/azure-rest-api-specs that referenced this pull request Jun 17, 2026
…llision fix) (Azure#43889)

Removes .github/arm-leases/postgresql/Microsoft.DBforPostgreSQL/PostgreSQL/lease.yaml
which case-collides with the sibling PostgreSql/lease.yaml on Windows/macOS
filesystems and is no longer referenced by the spec layout. The lowercase
PostgreSql/ folder matches the service folder casing introduced by
Azure/azure-rest-api-specs-pr#28858 / Azure#43777
(postgresql folder restructure), so keeping PostgreSql/ preserves lease
coverage for that PR while eliminating the case-only duplicate.

Supersedes Azure#43887, which removed the lowercase variant; removing the lowercase
one would re-trigger ARMModelingReviewRequired on the partner restructure PR
because the lease checker looks up the exact-cased path.

Co-authored-by: Vikeshi Tiwari <vikestiwari@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants