Skip to content

[Key Vault] Make ManagedHsmSkuName an extensible enum (modelAsString: true) #44008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neerjagangwar merged 4 commits into from
Jun 23, 2026
+60 −6
Merged

[Key Vault] Make ManagedHsmSkuName an extensible enum (modelAsString: true) #44008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
939d6f4
update managed hsm sku enum to string
neerja581 Jun 16, 2026
16dccb6
update
neerja581 Jun 19, 2026
5bd4295
Fix tsp formatting: wrap @typeChangedFrom decorator to satisfy TypeSp…
neerja581 Jun 19, 2026
0906077
Merge branch 'main' into ngangwar/mhsm-sku-name-update
neerjagangwar Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/KeyVault/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ enum KeyVaultNameUnavailableReason {
/**
* SKU of the managed HSM Pool
*/
#suppress "@azure-tools/typespec-azure-core/no-enum" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
#suppress "@azure-tools/typespec-azure-core/no-enum" "Closed enum retained unchanged for already-released GA API versions 2025-05-01 and 2026-02-01 per Azure Breaking Changes Board guidance; superseded by the extensible union ManagedHsmSkuNameV2 starting in 2026-03-01-preview."
enum ManagedHsmSkuName {
Standard_B1,
Custom_B32,
Expand All @@ -597,6 +597,29 @@ enum ManagedHsmSkuName {
Custom_C10,
}

/**
* SKU of the managed HSM Pool
*/
@Versioning.added(KeyVault.Versions.v2026_03_01_preview)
union ManagedHsmSkuNameV2 {
string,

/** Standard_B1 SKU */
Standard_B1: "Standard_B1",

/** Custom_B32 SKU */
Custom_B32: "Custom_B32",

/** Custom_B6 SKU */
Custom_B6: "Custom_B6",

/** Custom_C42 SKU */
Custom_C42: "Custom_C42",

/** Custom_C10 SKU */
Custom_C10: "Custom_C10",
}

/**
* The parameters used to create a key.
*/
Expand Down Expand Up @@ -1906,7 +1929,11 @@ model ManagedHsmSku {
/**
* SKU of the managed HSM Pool
*/
name: ManagedHsmSkuName;
@Versioning.typeChangedFrom(
KeyVault.Versions.v2026_03_01_preview,
ManagedHsmSkuName
)
name: ManagedHsmSkuNameV2;
Comment thread
heaths marked this conversation as resolved.
}

/**
Expand Down
35 changes: 31 additions & 4 deletions ...ault/resource-manager/Microsoft.KeyVault/KeyVault/preview/2026-03-01-preview/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4611,7 +4611,7 @@
"description": "SKU Family of the managed HSM Pool"
},
"name": {
"$ref": "#/definitions/ManagedHsmSkuName",
"$ref": "#/definitions/ManagedHsmSkuNameV2",
"description": "SKU of the managed HSM Pool"
}
},
Expand Down Expand Up @@ -4642,7 +4642,7 @@
]
}
},
"ManagedHsmSkuName": {
"ManagedHsmSkuNameV2": {
"type": "string",
"description": "SKU of the managed HSM Pool",
"enum": [
Expand All @@ -4653,8 +4653,35 @@
"Custom_C10"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
"modelAsString": false
"name": "ManagedHsmSkuNameV2",
"modelAsString": true,
"values": [
{
"name": "Standard_B1",
"value": "Standard_B1",
"description": "Standard_B1 SKU"
},
{
"name": "Custom_B32",
"value": "Custom_B32",
"description": "Custom_B32 SKU"
},
{
"name": "Custom_B6",
"value": "Custom_B6",
"description": "Custom_B6 SKU"
},
{
"name": "Custom_C42",
"value": "Custom_C42",
"description": "Custom_C42 SKU"
},
{
"name": "Custom_C10",
"value": "Custom_C10",
"description": "Custom_C10 SKU"
}
]
}
},
"ManagedHsmTrigger": {
Expand Down
Loading