Skip to content

Refactor(nginx): migrate to unified folder structure#44162

Open
v-xuto wants to merge 3 commits into
Azure:mainfrom
v-xuto:nginx-refactor
Open

Refactor(nginx): migrate to unified folder structure#44162
v-xuto wants to merge 3 commits into
Azure:mainfrom
v-xuto:nginx-refactor

Conversation

@v-xuto

@v-xuto v-xuto commented Jun 23, 2026

Copy link
Copy Markdown
Member

This PR migrates the nginx specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under resource-manager\Nginx.NginxPlus\ginxPlus
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Verified TypeSpec compilation works correctly
  • Updated the relevant paths in specification/suppressions.yaml file
  • Updated the relevant paths in cspell.yaml file
  • Add rpaas readme.md under resource-manger

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@v-xuto v-xuto added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Jun 23, 2026
@github-actions

Copy link
Copy Markdown

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the CI-RpaaSRPNotInPrivateRepo label.
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMModelingReviewRequired label. This means it is introducing a new Resource Provider namespace or a new resource type. New RPs and new resource types require a discussion with the ARM Modeling Review team before merging.

    If you haven't discussed yet:
    Please schedule a meeting at ARM API Modeling Office Hours.

    If ARMModelingSignedOff label was removed by automation:
    This happens when the lease file is not found. Please check with the PM you discussed your design with to confirm if the lease file PR has been merged. In the public repo, lease files reflect immediately after merge. In the private repo (azure-rest-api-specs-pr), lease files typically sync within a few hours, but it can take up to 1-2 business days depending on sync pipeline timing and queue load. Please wait for the sync to complete.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR has CI-RpaaSRPNotInPrivateRepo label. This means it is introducing a new RP (Resource Provider) namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. To resolve, first submit and merge a PR with the new RP namespace to the RPSaaSMasterbranch.This PR will remain blocked until then.


Comment generated by summarize-checks workflow run.

@github-actions

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Nginx.NginxPlus-Nginx
TypeSpec Nginx.NginxPlus

Comment generated by After APIView workflow run.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Nginx.NginxPlus
Python azure-mgmt-nginx
Swagger Nginx.NginxPlus-NginxPlus

Comment generated by After APIView workflow run.

@v-xuto v-xuto marked this pull request as ready for review June 24, 2026 08:27
@v-xuto v-xuto added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-LintDiff and removed NotReadyForARMReview labels Jun 24, 2026
@github-actions github-actions Bot added NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jun 24, 2026

@qiaozha qiaozha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service name should be NginxPlus

@v-xuto

v-xuto commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

The service name should be NginxPlus

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants