Skip to content

Add csharp customizations for DomainServices migration#44389

Open
cxznmhdcxz wants to merge 4 commits into
Azure:mainfrom
cxznmhdcxz:domainservices-csharp-mgmt-onboard
Open

Add csharp customizations for DomainServices migration#44389
cxznmhdcxz wants to merge 4 commits into
Azure:mainfrom
cxznmhdcxz:domainservices-csharp-mgmt-onboard

Conversation

@cxznmhdcxz

Copy link
Copy Markdown
Member

Adds C# management-plane (http-client-csharp-mgmt) customizations for onboarding the Azure.ResourceManager.DomainServices SDK (API version 2025-10-01-preview).

Changes

  • tspconfig.yaml: add @azure-typespec/http-client-csharp-mgmt emitter section (namespace Azure.ResourceManager.DomainServices).
  • client.tsp (new), C#-scoped decorators:
    • @@alternateType(Resource.id, armResourceIdentifier) - common-types v3 models id as a plain string; maps it to ResourceIdentifier so generated ResourceData ctors compile.
    • @@clientName(UnsuspendDomainServiceResponse -> DomainServiceUnsuspendResult) - fixes AZC0030 (model may not end in Response).
    • @@clientName(DomainServices -> DomainServiceOperationGroup) - the DomainServices interface generated an internal REST class colliding with the namespace's last segment; rename avoids the _DomainServices namespace escape (internal, no public API impact).

Companion SDK PR: Azure/azure-sdk-for-net onboarding Azure.ResourceManager.DomainServices.

Add @azure-typespec/http-client-csharp-mgmt emitter to tspconfig and client.tsp with C#-scoped customizations (Resource.id alternateType, AZC0030 model rename, operation-group rename to avoid namespace collision).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added resource-manager TypeSpec Authored with TypeSpec labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.AAD
C# Azure.ResourceManager.DomainServices
Java com.azure.resourcemanager:azure-resourcemanager-domainservices

Comment generated by After APIView workflow run.

cxznmhdcxz and others added 2 commits July 2, 2026 17:11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Location, DateTime naming, Status rename)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@cxznmhdcxz cxznmhdcxz force-pushed the domainservices-csharp-mgmt-onboard branch from cf49bcd to 1bfa947 Compare July 3, 2026 03:17
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review July 3, 2026 04:19
@github-actions github-actions Bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 3, 2026
…t IDs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant