Skip to content

[BillingTrust] Add .NET client renames for Assessment/Rule resource trios (RESNAME001)#44467

Merged
abhimrnandan-ms merged 2 commits into
mainfrom
users/abmohanr/billingtrust-dotnet-resname
Jul 7, 2026
Merged

[BillingTrust] Add .NET client renames for Assessment/Rule resource trios (RESNAME001)#44467
abhimrnandan-ms merged 2 commits into
mainfrom
users/abmohanr/billingtrust-dotnet-resname

Conversation

@abhimrnandan-ms

Copy link
Copy Markdown
Contributor

Summary

Adds .NET-only client renames for the Assessment and Rule resource trios to satisfy the Azure .NET SDK deterministic naming rule RESNAME001 (resource type nouns must carry RP/domain context to avoid collisions across management packages).

Why

The .NET Management SDK review on azure-sdk-for-net#60598 flagged 2 RESNAME001 blocking violations (5 types): the bare nouns Assessment and Rule collide with types in other packages (e.g., Azure.ResourceManager.Security.AssessmentData).

Change

client.tsp only:

@@clientName(Assessment, "BillingTrustAssessment", "csharp");
@@clientName(Rule, "BillingTrustRule", "csharp");

Produces in .NET:

  • BillingTrustAssessmentResource / BillingTrustAssessmentData

  • BillingTrustRuleResource / BillingTrustRuleData / BillingTrustRuleCollection

  • Client-only, csharp-scoped — does not change the wire contract, openapi.json, or any other language SDK.

  • Verified locally: tsp compile succeeds and openapi.json is unchanged.

  • Follows the same @@clientName/csharp pattern already used for ProvisioningState and GenerateUploadTokenResponse.

Related

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMAutoSignedOff-Trivial ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jul 6, 2026
@abhimrnandan-ms abhimrnandan-ms enabled auto-merge (squash) July 7, 2026 00:00
@github-actions github-actions Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.BillingTrust
Go sdk/resourcemanager/billingtrust/armbillingtrust

Comment generated by After APIView workflow run.

@abhimrnandan-ms abhimrnandan-ms added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jul 7, 2026
@abhimrnandan-ms abhimrnandan-ms merged commit 0e76f4e into main Jul 7, 2026
61 checks passed
@abhimrnandan-ms abhimrnandan-ms deleted the users/abmohanr/billingtrust-dotnet-resname branch July 7, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff-Trivial ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants